[jira] [Comment Edited] (MESOS-6726) IOSwitchboardServerFlags adds flags for non-optional fields w/o providing a default value

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739746#comment-15739746 ] 

Benjamin Bannier edited comment on MESOS-6726 at 12/11/16 1:33 PM:
-------------------------------------------------------------------

Above RR was committed without updating the RR and ignoring raised issues.


was (Author: bbannier):
Above RR was committed without updating the RR and and ignoring raised issues.

> IOSwitchboardServerFlags adds flags for non-optional fields w/o providing a default value
> -----------------------------------------------------------------------------------------
>
>                 Key: MESOS-6726
>                 URL: https://issues.apache.org/jira/browse/MESOS-6726
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Bannier
>            Assignee: Kevin Klues
>              Labels: tech-debt
>             Fix For: 1.2.0
>
>
> The class {{IOSwitchboardFlags}} contains a number of members of non-{{Option}}, fundamental type (i.e., types which do not have constructors). As customary for a {{Flags}} class, these fields are not initialized since usually the initialization is done by the calling the correct overload of {{FlagsBase::add}} taking a default value.
> The class {{IOSwitchbardFlags}} calls an {{add}} overload acting on a non-{{Option}} member which does not take the default value. This can lead to the members containing garbage values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)