You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/15 19:07:28 UTC
Review Request 64657: Added tests for VIEW_STANDALONE_CONTAINER ACL.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64657/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Greg Mann.
Repository: mesos
Description
-------
Added tests for VIEW_STANDALONE_CONTAINER ACL.
Diffs
-----
src/tests/authorization_tests.cpp 35eecc8970fae09ca38b322f0f2575a086b6ecd7
Diff: https://reviews.apache.org/r/64657/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 64657: Added tests for VIEW_STANDALONE_CONTAINER
ACL.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64657/#review193987
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/authorization_tests.cpp
Lines 5379 (patched)
<https://reviews.apache.org/r/64657/#comment272680>
Remove extra period.
- Greg Mann
On Dec. 15, 2017, 7:07 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64657/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 7:07 p.m.)
>
>
> Review request for mesos, Gilbert Song and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for VIEW_STANDALONE_CONTAINER ACL.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 35eecc8970fae09ca38b322f0f2575a086b6ecd7
>
>
> Diff: https://reviews.apache.org/r/64657/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 64657: Added tests for VIEW_STANDALONE_CONTAINER
ACL.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64657/#review193969
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64628', '64638', '64639', '64653', '64654', '64655', '64656', '64657']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64657
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64657/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2376 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2400 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2372 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2396 ms total)
[----------] Global test environment tear-down
[==========] 836 tests from 85 test cases ran. (310974 ms total)
[ PASSED ] 826 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
10 FAILED TESTS
YOU HAVE 213 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64657/logs/mesos-tests-stderr.log):
```
I1215 20:20:35.306864 9580 master.cpp:10158] Updating the state of task 3d5da677-c5e0-41d9-94ac-af1fe267cdee of framework 7d86efd4-8ed7-449e-874f-ab52cd471258-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1215 20:20:35.307835 8928 slave.cpp:3401] Shutting down framework 7d86efd4-8ed7-449e-874f-ab52cd471258-0000
I1215 20:20:35.307835 8928 slave.cpp:6109] Shutting down executor '3d5da677-c5e0-41d9-94ac-af1fI1215 20:20:34.624876 8448 exec.cpp:162] Version: 1.5.0
I1215 20:20:34.649875 100 exec.cpp:237] Executor registered on agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0
I1215 20:20:34.652901 8688 executor.cpp:171] Received SUBSCRIBED event
I1215 20:20:34.657873 8688 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 20:20:34.657873 8688 executor.cpp:171] Received LAUNCH event
I1215 20:20:34.661872 8688 executor.cpp:638] Starting task 3d5da677-c5e0-41d9-94ac-af1fe267cdee
I1215 20:20:34.738867 8688 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1215 20:20:35.280838 8688 executor.cpp:651] Forked command at 2616
I1215 20:20:35.309836 7212 exec.cpp:435] Executor asked to shutdown
I1215 20:20:35.309836 8688 executor.cpp:171] Received SHUTDOWN event
I1215 20:20:35.309836 8688 executor.cpp:748] Shutting down
I1215 20:20:35.309836 8688 executor.cpp:855] Sending SIGTERM to process tree at pid 2e267cdee' of framework 7d86efd4-8ed7-449e-874f-ab52cd471258-0000 at executor(1)@10.3.1.11:56430
I1215 20:20:35.308862 8928 slave.cpp:909] Agent terminating
W1215 20:20:35.308862 8928 slave.cpp:3397] Ignoring shutdown framework 7d86efd4-8ed7-449e-874f-ab52cd471258-0000 because it is terminating
I1215 20:20:35.309836 9580 master.cpp:10264] Removing task 3d5da677-c5e0-41d9-94ac-af1fe267cdee with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7d86efd4-8ed7-449e-874f-ab52cd471258-0000 on agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0 at slave(327)@10.3.1.11:56409 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 20:20:35.310837 3132 containerizer.cpp:2352] Destroying container 07b80261-62e9-4229-b099-c1cceaacf817 in RUNNING state
I1215 20:20:35.310837 3132 containerizer.cpp:2955] Transitioning the state of container 07b80261-62e9-4229-b099-c1cceaacf817 from RUNNING to DESTROYING
I1215 20:20:35.310837 9580 master.cpp:1305] Agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0 at slave(327)@10.3.1.11:56409 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1215 20:20:35.311836 9580 master.cpp:3364] Disconnecting agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0 at slave(327)@10.3.1.11:56409 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 20:20:35.311836 3132 launcher.cpp:156] Asked to destroy container 07b80261-62e9-4229-b099-c1cceaacf817
I1215 20:20:35.311836 9580 master.cpp:3383] Deactivating agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0 at slave(327)@10.3.1.11:56409 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 20:20:35.312837 8436 hierarchical.cpp:344] Removed framework 7d86efd4-8ed7-449e-874f-ab52cd471258-0000
I1215 20:20:35.312837 8436 hierarchical.cpp:766] Agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0 deactivated
I1215 20:20:35.399000 8928 containerizer.cpp:2803] Container 07b80261-62e9-4229-b099-c1cceaacf817 has exited
I1215 20:20:35.428048 1496 master.cpp:1147] Master terminating
I1215 20:20:35.431044 9580 hierarchical.cpp:609] Removed agent 7d86efd4-8ed7-449e-874f-ab52cd471258-S0
I1215 20:20:35.734165 9836 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 15, 2017, 7:07 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64657/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 7:07 p.m.)
>
>
> Review request for mesos, Gilbert Song and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for VIEW_STANDALONE_CONTAINER ACL.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 35eecc8970fae09ca38b322f0f2575a086b6ecd7
>
>
> Diff: https://reviews.apache.org/r/64657/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>