You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/10 15:24:47 UTC
[GitHub] [spark] cloud-fan opened a new pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
cloud-fan opened a new pull request #28785:
URL: https://github.com/apache/spark/pull/28785
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/23388 .
https://github.com/apache/spark/pull/23388 has an issue: it doesn't handle subquery expressions and assumes they will be turned into joins. However, this is not true for non-correlated subquery expressions.
This PR fixes this issue. It now doesn't skip `Subquery`, and subquery expressions will be handled by `OptimizeSubqueries`, which runs the optimizer with the subquery.
Note that, correlated subquery expressions will be handled twice: once in `OptimizeSubqueries`, once later when it becomes join. This is OK as `NormalizeFloatingNumbers` is idempotent now.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix a bug
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, see the newly added test.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28785:
URL: https://github.com/apache/spark/pull/28785#discussion_r438568381
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -56,10 +56,6 @@ import org.apache.spark.sql.types._
object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan match {
- // A subquery will be rewritten into join later, and will go through this rule
- // eventually. Here we skip subquery, as we only need to run this rule once.
- case _: Subquery => plan
Review comment:
No we can't.
This fix relies on the rule `OptimizeSubqueries`, which is an inner object of the `class Optimizer` as it needs to rerun the entire optimizer for subquery. So we can't use `OptimizeSubqueries` in `NormalizeFloatingPointNumbersSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642086777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642273246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642273246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28785:
URL: https://github.com/apache/spark/pull/28785#discussion_r438571966
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -56,10 +56,6 @@ import org.apache.spark.sql.types._
object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
Review comment:
I see. Makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28785:
URL: https://github.com/apache/spark/pull/28785#discussion_r438241316
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -56,10 +56,6 @@ import org.apache.spark.sql.types._
object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan match {
- // A subquery will be rewritten into join later, and will go through this rule
- // eventually. Here we skip subquery, as we only need to run this rule once.
- case _: Subquery => plan
Review comment:
How about adding tests for the subquery case in `NormalizeFloatingPointNumbersSuite`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28785:
URL: https://github.com/apache/spark/pull/28785#discussion_r438569515
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -56,10 +56,6 @@ import org.apache.spark.sql.types._
object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
Review comment:
ah yea, actually it's better to execute it before the `RewriteSubquery`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642083355
cc @hvanhovell @maropu @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28785:
URL: https://github.com/apache/spark/pull/28785#discussion_r438569515
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -56,10 +56,6 @@ import org.apache.spark.sql.types._
object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
Review comment:
it's still true, the correlated subquery becomes join, and may have new join keys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28785:
URL: https://github.com/apache/spark/pull/28785#discussion_r438568623
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -56,10 +56,6 @@ import org.apache.spark.sql.types._
object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
Review comment:
Does it also mean `This batch must be executed after the `RewriteSubquery` batch, which creates joins.` is not definitely true now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642272229
**[Test build #123771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123771/testReport)** for PR 28785 at commit [`4dc6413`](https://github.com/apache/spark/commit/4dc641393de0458b3fe4cfa980c8a8b2c3327ea0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642443401
thanks for the review, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642086777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642086267
**[Test build #123771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123771/testReport)** for PR 28785 at commit [`4dc6413`](https://github.com/apache/spark/commit/4dc641393de0458b3fe4cfa980c8a8b2c3327ea0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28785:
URL: https://github.com/apache/spark/pull/28785#issuecomment-642086267
**[Test build #123771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123771/testReport)** for PR 28785 at commit [`4dc6413`](https://github.com/apache/spark/commit/4dc641393de0458b3fe4cfa980c8a8b2c3327ea0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28785: [SPARK-31958][SQL] normalize special floating numbers in subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28785:
URL: https://github.com/apache/spark/pull/28785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org