[GitHub] [druid] clintropolis commented on pull request #10680: integration test for coordinator and overlord leadership client

[GitBox <gi...@apache.org>]

clintropolis commented on pull request #10680:
URL: https://github.com/apache/druid/pull/10680#issuecomment-747062798


   I made another change to this PR after it was approved, which was to split out the logic in `docker_run_cluster.sh` which picks which compose file to use for the tests into a new file `docker_compose_args.sh` which provides the function `getComposeArgs`. 
   
   In `docker_run_cluster.sh` it is used like 
   
   ```bash
   docker-compose $(getComposeArgs) up -d
   ```
   
   and the main reason for this change, was to modify `stop_cluster.sh` so that it could do the same-ish thing to stop the cluster
   
   ```bash
   docker-compose $(getComposeArgs) down
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org