You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/19 10:00:34 UTC

[GitHub] [iotdb] jun0315 opened a new pull request #4434: [IOTDB-2036] RestApiServiceImpl access to BasicServiceProvider

jun0315 opened a new pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434


   see :https://issues.apache.org/jira/browse/IOTDB-2036


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4434: [IOTDB-2036] RestApiServiceImpl accesses to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#issuecomment-973970700


   
   [![Coverage Status](https://coveralls.io/builds/44407044/badge)](https://coveralls.io/builds/44407044)
   
   Coverage decreased (-0.03%) to 66.97% when pulling **8e17170eef4c05b34e17b6cb705b0762ef8afeda on jun0315:rest_access_basic** into **05158d177376b698ab60466db6d4373487f9c9a4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4434: [IOTDB-2036] RestApiServiceImpl access to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#issuecomment-973970700


   
   [![Coverage Status](https://coveralls.io/builds/44401801/badge)](https://coveralls.io/builds/44401801)
   
   Coverage decreased (-0.03%) to 66.914% when pulling **73a42806a2fe6b81d27daf00e471284babe7f04a on jun0315:rest_access_basic** into **fc31d50709e6b1f1bae1598232e45c5510b135ae on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #4434: [IOTDB-2036] RestApiServiceImpl accesses to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4434: [IOTDB-2036] RestApiServiceImpl access to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#discussion_r753059113



##########
File path: server/src/main/java/org/apache/iotdb/db/rest/impl/RestApiServiceImpl.java
##########
@@ -38,16 +31,18 @@
 import org.apache.iotdb.db.rest.model.ExecutionStatus;
 import org.apache.iotdb.db.rest.model.InsertTabletRequest;
 import org.apache.iotdb.db.rest.model.SQL;
+import org.apache.iotdb.db.service.basic.BasicServiceProvider;
 import org.apache.iotdb.rpc.TSStatusCode;
 
 import javax.ws.rs.core.Response;
 import javax.ws.rs.core.SecurityContext;
 
 public class RestApiServiceImpl extends RestApiService {
 
-  protected final IPlanExecutor executor = new PlanExecutor(); // todo cluster
   protected final Planner planner = new Planner();
 
+  public BasicServiceProvider basicServiceProvider = new BasicServiceProvider();

Review comment:
       ```suggestion
     protected final BasicServiceProvider basicServiceProvider = new BasicServiceProvider();
   ```

##########
File path: server/src/main/java/org/apache/iotdb/db/rest/impl/RestApiServiceImpl.java
##########
@@ -95,8 +90,7 @@ public Response executeQueryStatement(SQL sql, SecurityContext securityContext)
         return response;
       }
       return QueryDataSetHandler.fillDateSet(
-          QueryDataSetHandler.constructQueryDataSet(executor, physicalPlan),

Review comment:
       Remove QueryDataSetHandler if it is useless :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4434: [IOTDB-2036] RestApiServiceImpl accesses to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#issuecomment-973970700


   
   [![Coverage Status](https://coveralls.io/builds/44404566/badge)](https://coveralls.io/builds/44404566)
   
   Coverage decreased (-0.02%) to 66.977% when pulling **bd95461dca0460f3d53931b6eba5ff6919143ebf on jun0315:rest_access_basic** into **05158d177376b698ab60466db6d4373487f9c9a4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4434: [IOTDB-2036] RestApiServiceImpl access to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#issuecomment-973970700


   
   [![Coverage Status](https://coveralls.io/builds/44402149/badge)](https://coveralls.io/builds/44402149)
   
   Coverage decreased (-0.04%) to 66.899% when pulling **73a42806a2fe6b81d27daf00e471284babe7f04a on jun0315:rest_access_basic** into **fc31d50709e6b1f1bae1598232e45c5510b135ae on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4434: [IOTDB-2036] RestApiServiceImpl accesses to BasicServiceProvider

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#issuecomment-973970700


   
   [![Coverage Status](https://coveralls.io/builds/44404718/badge)](https://coveralls.io/builds/44404718)
   
   Coverage decreased (-0.03%) to 66.967% when pulling **bd95461dca0460f3d53931b6eba5ff6919143ebf on jun0315:rest_access_basic** into **05158d177376b698ab60466db6d4373487f9c9a4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org