[jira] [Created] (TS-4634) HttpCacheSM should not be checking redirection retries

["James Peach (JIRA)" <ji...@apache.org>]

James Peach created TS-4634:
-------------------------------

             Summary: HttpCacheSM should not be checking redirection retries
                 Key: TS-4634
                 URL: https://issues.apache.org/jira/browse/TS-4634
             Project: Traffic Server
          Issue Type: Bug
          Components: Cache, HTTP
            Reporter: James Peach


In {{HttpCacheSM.cc}}:

{code}
   336    if (open_write_tries > master_sm->redirection_tries &&
   337        open_write_tries > master_sm->t_state.txn_conf->max_cache_open_write_retries) {
   338      master_sm->handleEvent(CACHE_EVENT_OPEN_WRITE_FAILED, (void *)-ECACHE_DOC_BUSY);
   339      return ACTION_RESULT_DONE;
   340    }
{code}

First, you are not supposed check ``redirection_retries`` without first checking ``enable_redirection``. Second, redirection retries should be handled above this layer; it seems really hokey to have this check smuggled into the HTTP cache layer. Presumably if the HTTP state machine has already decided to retry a redirect we should not be second guessing that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)