You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "melroy12 (via GitHub)" <gi...@apache.org> on 2025/07/02 22:20:42 UTC
[PR] rustup version [datafusion]
melroy12 opened a new pull request, #16663:
URL: https://github.com/apache/datafusion/pull/16663
## Which issue does this PR close?
- Closes #16655.
## Rationale for this change
Improve build times.
## What changes are included in this PR?
Rust 1.88.0 is properly configured and active
All toolchain components (rustfmt, clippy) are working
The DataFusion workspace compiles cleanly with the new Rust version
No warnings or errors detected
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes

## Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to Rust 1.88 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3038886263
> > Thanks @melroy12 -- I started the CI tests
> > I suspect this PR will fail at least `clippy` -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do `clippy --fix` which will fix some issues)
>
> I did check before pushing the code , I couldn't find any warnings @alamb
Looks like we have already addressed the clippy errors in previous PRs. Thank you @melroy12 and @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to Rust 1.88 [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #16663:
URL: https://github.com/apache/datafusion/pull/16663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to Rust 1.88 [datafusion]
Posted by "melroy12 (via GitHub)" <gi...@apache.org>.
melroy12 commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3033695701
> Thanks @melroy12 -- I started the CI tests
>
> I suspect this PR will fail at least `clippy` -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do `clippy --fix` which will fix some issues)
I did check before pushing the code , I couldn't find any warnings @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update to Rust 1.88 [datafusion]
Posted by "melroy12 (via GitHub)" <gi...@apache.org>.
melroy12 commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3033691052
> Thanks @melroy12 -- I started the CI tests
>
> I suspect this PR will fail at least `clippy` -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do `clippy --fix` which will fix some issues)
actually I did check before pushing the code , But I couldnt find any warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] rustup version [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3033663294
Thanks @melroy12 -- I started the CI tests
I suspect this PR will fail at least `clippy` -- you'll perhaps have to run Clippy and make the changes it suggests (note you can also do `clippy --fix` which will fix some issues)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org