You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vishnu667 <gi...@git.apache.org> on 2016/04/20 02:33:18 UTC
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
GitHub user vishnu667 opened a pull request:
https://github.com/apache/spark/pull/12513
[SPARK-14739][Python] Fix for Sparse and Dense Vector Parsing Errors
## What changes were proposed in this pull request?
Fixed parsing empty dense and sparse vectors, corrected dead parsing tests.
## How was this patch tested?
Fixed parsing tests, added tests specific to SPARK-14739
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vishnu667/spark SPARK-14739
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12513
----
commit 895daaf672d1e4f528ebe0dab978f6d2f6630bd4
Author: Vishnu Prasad <vi...@gmail.com>
Date: 2016-04-20T00:20:25Z
[SPARK-14739][Python] Fix for Both Sparse and Dense Vector Parsing Errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212384071
**[Test build #56351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56351/consoleFull)** for PR 12513 at commit [`e63b6b2`](https://github.com/apache/spark/commit/e63b6b2ec58ab249b854121978e818b5ddac3ed2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212366770
Yes @vishnu667 please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212386907
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212184679
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by vishnu667 <gi...@git.apache.org>.
Github user vishnu667 commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212852659
#12516
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by vishnu667 <gi...@git.apache.org>.
Github user vishnu667 closed the pull request at:
https://github.com/apache/spark/pull/12513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212386810
**[Test build #56351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56351/consoleFull)** for PR 12513 at commit [`e63b6b2`](https://github.com/apache/spark/commit/e63b6b2ec58ab249b854121978e818b5ddac3ed2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212836969
Thank you @vishnu667 for the assist, you can close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212320556
duplicate to #12516.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212383127
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212369153
Good point, but please make that comment on the existing PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by vishnu667 <gi...@git.apache.org>.
Github user vishnu667 commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212367950
@viirya @srowen
#12516 Has not Fixed the Incorrect Test cases and has only added his test case to the existing
They have been comparing the parsing the values using assertTrue instead of assertEquals.
[Fix for the Existing previous test cases](https://github.com/apache/spark/pull/12513/commits/c5f2510a8a53e54502a45fce7893ed1f6c7a0510)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212526952
EDIT again: OK, see discussion on https://github.com/apache/spark/pull/12516 about why maybe that's fairer to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by vishnu667 <gi...@git.apache.org>.
Github user vishnu667 commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212382864
@srowen I've tested both the PR and both have the issue Fixed the only difference is the test case I've mentioned earlier which is already patched in this request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212395273
Looks pretty good to me based on my understanding of the issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212386910
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56351/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14739][Python] Fix for Sparse and Dense...
Posted by arashpa <gi...@git.apache.org>.
Github user arashpa commented on the pull request:
https://github.com/apache/spark/pull/12513#issuecomment-212519960
@srowen I had another PR https://github.com/apache/spark/pull/12510 coming in first but made a mistake by closing it. I'm also the original person who found the bug and created the first solution for it. Please if possible consider #12516 as the candidate solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org