You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2018/04/19 17:25:43 UTC
[GitHub] madlib pull request #266: Release 1.14: Version numbering and upgrade relate...
GitHub user orhankislal opened a pull request:
https://github.com/apache/madlib/pull/266
Release 1.14: Version numbering and upgrade related changes
Updates the version number to 1.14 for the release candidate.
Updates the changelists and other related files for upgrade.
Note that upgrade is not supported from versions prior to 1.11.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib rel/upgrade_v114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit c65351f29d7944b82e189489dad74128f8afe69f
Author: Orhan Kislal <ok...@...>
Date: 2018-04-19T17:23:47Z
Release 1.14: Version numbering and upgrade related changes
Updates the version number to 1.14 for the release candidate.
Updates the changelists and other related files for upgrade.
Note that upgrade is not supported from versions prior to 1.11.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
----
---
[GitHub] madlib issue #266: Release 1.14: Version numbering and upgrade related chang...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/266
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/460/
---
[GitHub] madlib pull request #266: Release 1.14: Version numbering and upgrade relate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/266
---
[GitHub] madlib issue #266: Release 1.14: Version numbering and upgrade related chang...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:
https://github.com/apache/madlib/pull/266
Thanks for the comments Rahul.
---
[GitHub] madlib pull request #266: Release 1.14: Version numbering and upgrade relate...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/266#discussion_r183492733
--- Diff: src/madpack/changelist_1.13_1.14.yaml ---
@@ -0,0 +1,97 @@
+# ------------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# ------------------------------------------------------------------------------
+
+# Changelist for MADlib version 1.13 to 1.14
+
+# This file contains all changes that were introduced in a new version of
+# MADlib. This changelist is used by the upgrade script to detect what objects
+# should be upgraded (while retaining all other objects from the previous version)
+
+# New modules (actually .sql_in files) added in upgrade version
+# For these files the sql_in code is retained as is with the functions in the
+# file installed on the upgrade version. All other files (that don't have
+# updates), are cleaned up to remove object replacements
+new module:
+ # ----------------- Changes from 1.13 to 1.14 --------
--- End diff --
Added the missing modules.
---
[GitHub] madlib pull request #266: Release 1.14: Version numbering and upgrade relate...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/266#discussion_r182920951
--- Diff: src/madpack/changelist_1.13_1.14.yaml ---
@@ -0,0 +1,97 @@
+# ------------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# ------------------------------------------------------------------------------
+
+# Changelist for MADlib version 1.13 to 1.14
+
+# This file contains all changes that were introduced in a new version of
+# MADlib. This changelist is used by the upgrade script to detect what objects
+# should be upgraded (while retaining all other objects from the previous version)
+
+# New modules (actually .sql_in files) added in upgrade version
+# For these files the sql_in code is retained as is with the functions in the
+# file installed on the upgrade version. All other files (that don't have
+# updates), are cleaned up to remove object replacements
+new module:
+ # ----------------- Changes from 1.13 to 1.14 --------
--- End diff --
Not sure if this is only for "module" or for any sql_in file - balance datasets is a new file added in this version.
---
[GitHub] madlib pull request #266: Release 1.14: Version numbering and upgrade relate...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/266#discussion_r182921752
--- Diff: src/madpack/upgrade_util.py ---
@@ -82,16 +82,21 @@ def _get_function_info(self, oid):
proname,
textin(regtypeout(prorettype::regtype)) AS rettype,
CASE array_upper(proargtypes,1) WHEN -1 THEN ''
- ELSE textin(regtypeout(unnest(proargtypes)::regtype))
+ ELSE textin(regtypeout(foo))
END AS argtype,
CASE WHEN proargnames IS NULL THEN ''
- ELSE unnest(proargnames)
+ ELSE bar
END AS argname,
CASE array_upper(proargtypes,1) WHEN -1 THEN 1
- ELSE generate_series(0, array_upper(proargtypes, 1))
+ ELSE zee
END AS i
FROM
- pg_proc AS p
+ (SELECT *, oid,
+ unnest(proargtypes)::regtype AS foo,
--- End diff --
why the non-meaningful names? And while we're here, could we please add some comments on what's happening in the query?
---
[GitHub] madlib issue #266: Release 1.14: Version numbering and upgrade related chang...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/266
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/458/
---
[GitHub] madlib issue #266: Release 1.14: Version numbering and upgrade related chang...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/266
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/461/
---
[GitHub] madlib pull request #266: Release 1.14: Version numbering and upgrade relate...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/266#discussion_r183180223
--- Diff: src/madpack/upgrade_util.py ---
@@ -82,16 +82,21 @@ def _get_function_info(self, oid):
proname,
textin(regtypeout(prorettype::regtype)) AS rettype,
CASE array_upper(proargtypes,1) WHEN -1 THEN ''
- ELSE textin(regtypeout(unnest(proargtypes)::regtype))
+ ELSE textin(regtypeout(foo))
END AS argtype,
CASE WHEN proargnames IS NULL THEN ''
- ELSE unnest(proargnames)
+ ELSE bar
END AS argname,
CASE array_upper(proargtypes,1) WHEN -1 THEN 1
- ELSE generate_series(0, array_upper(proargtypes, 1))
+ ELSE zee
END AS i
FROM
- pg_proc AS p
+ (SELECT *, oid,
+ unnest(proargtypes)::regtype AS foo,
--- End diff --
We changed the query because PG 10 does not allow set returning functions in the `CASE` clause any more.
---