You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2024/03/08 12:45:41 UTC

(causeway) 01/01: CAUSEWAY-3692: renames to PrecedingParamsPolicy (enum x2, config prop and @Parameter attribute)

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch CAUSEWAY-3692
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit b3795574b191494e0fd6548deb1ec60c30324378
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Fri Mar 8 12:44:02 2024 +0000

    CAUSEWAY-3692: renames to PrecedingParamsPolicy (enum x2, config prop and @Parameter attribute)
---
 .../causeway/applib/annotation/Parameter.java      | 11 +++-------
 ...aultsPolicy.java => PrecedingParamsPolicy.java} | 25 ++++++++++++++--------
 .../core/config/CausewayConfiguration.java         |  6 +++---
 .../metamodel/facets/ParameterConfigOptions.java   | 20 +++++++++++------
 .../parameter/ParameterAnnotationFacetFactory.java |  2 +-
 ...ActionFacetForActionAnnotationAsConfigured.java |  2 +-
 .../depdef/ParameterDependentDefaultsFacet.java    | 18 ++++++++--------
 .../ParameterDependentDefaultsFacetAbstract.java   |  4 ++--
 ...pendentDefaultsFacetForParameterAnnotation.java |  2 +-
 ...terDependentDefaultsFacetFromConfiguration.java |  2 +-
 .../spec/feature/ObjectActionParameter.java        |  4 ++--
 .../causeway/core/metamodel/util/Facets.java       |  4 ++--
 .../github/menu/LayoutLoadersGitHubMenu.java       | 12 +++++------
 .../applib/value/CalendarEventSemantics.java       |  8 +++----
 14 files changed, 64 insertions(+), 56 deletions(-)

diff --git a/api/applib/src/main/java/org/apache/causeway/applib/annotation/Parameter.java b/api/applib/src/main/java/org/apache/causeway/applib/annotation/Parameter.java
index ee6cae8349..d825be3d3e 100644
--- a/api/applib/src/main/java/org/apache/causeway/applib/annotation/Parameter.java
+++ b/api/applib/src/main/java/org/apache/causeway/applib/annotation/Parameter.java
@@ -135,16 +135,11 @@ public @interface Parameter {
             default "Doesn't match pattern";
 
     /**
-     * Whether dependent parameters should be reset to their default if an earlier parameter changes its
+     * Whether parameter values should be reset to their default if an earlier parameter changes its
      * value, or whether instead a parameter value, once changed by the end-user, should never be
      * overwritten even if the end-user changes an earlier parameter value.
      */
-    /**
-     * Whether this parameter should be reset to its default if an earlier parameter changes its
-     * value, or whether instead the parameter's value, once changed by the end-user, should never be
-     * overwritten even if the end-user changes an earlier parameter value.
-     */
-    DependentDefaultsPolicy dependentDefaultsPolicy()
-            default DependentDefaultsPolicy.AS_CONFIGURED;
+    PrecedingParamsPolicy precedingParamsPolicy()
+            default PrecedingParamsPolicy.AS_CONFIGURED;
 
 }
diff --git a/api/applib/src/main/java/org/apache/causeway/applib/annotation/DependentDefaultsPolicy.java b/api/applib/src/main/java/org/apache/causeway/applib/annotation/PrecedingParamsPolicy.java
similarity index 63%
rename from api/applib/src/main/java/org/apache/causeway/applib/annotation/DependentDefaultsPolicy.java
rename to api/applib/src/main/java/org/apache/causeway/applib/annotation/PrecedingParamsPolicy.java
index d8f08ae100..6dee3bb136 100644
--- a/api/applib/src/main/java/org/apache/causeway/applib/annotation/DependentDefaultsPolicy.java
+++ b/api/applib/src/main/java/org/apache/causeway/applib/annotation/PrecedingParamsPolicy.java
@@ -19,32 +19,39 @@
 package org.apache.causeway.applib.annotation;
 
 /**
- * The policies for calculating the defaults of dependent parameters.
+ * The policies for calculating the defaults of parameters if it has preceding parameters (isn't the first parameter,
+ * in other words).
  *
- * @since 1.x {@index}
+ * @since 2.x {@index}
  */
-public enum DependentDefaultsPolicy {
+public enum PrecedingParamsPolicy {
 
     /**
-     * The policy to use should be as per the default defaults policy configured in <tt>application.properties</tt>.
+     * The policy to use should be as per the preceding defaults policy configured in <tt>application.properties</tt>.
      *
      * <p>
-     *     If no defaults policy is configured, then default to the {@link DependentDefaultsPolicy#UPDATE_DEPENDENT UPDATE_DEPENDENT} policy.
+     *     If no defaults policy is configured, then default to the {@link PrecedingParamsPolicy#RESET RESET} policy.
      * </p>
      */
     AS_CONFIGURED,
 
     /**
-     * If an end-user has changed this parameter's value, then do not overwrite the value when an earlier parameter changes.
+     * If an end-user has changed this parameter's value, then do not overwrite the value when an earlier parameter
+     * changes.
+     *
+     * <P>
+     *     <b>WARNING</b>: If the parameter is constrained by dependent choices, then these will <i>not</i> be
+     *     re-evaluated.  The validation for the action should make sure that the parameter argument is validated
+     *     correctly.
+     * </P>
      */
     PRESERVE_CHANGES,
 
     /**
-     * If this parameter declares a default that is dependent on the value of a previous parameter, and that previous
-     * parameter has been changed by the end-user, then update this dependent parameter with its computed default,
+     * If a previous parameter is changed, then reset this parameter to its default,
      * <i>even if</i> the end-user has changed the value of this parameter previously.
      */
-    UPDATE_DEPENDENT,
+    RESET,
 
     /**
      * Ignore the value provided by this annotation (meaning that the framework will keep searching, in meta
diff --git a/core/config/src/main/java/org/apache/causeway/core/config/CausewayConfiguration.java b/core/config/src/main/java/org/apache/causeway/core/config/CausewayConfiguration.java
index 6ee570bb3d..b2dea70284 100644
--- a/core/config/src/main/java/org/apache/causeway/core/config/CausewayConfiguration.java
+++ b/core/config/src/main/java/org/apache/causeway/core/config/CausewayConfiguration.java
@@ -1513,16 +1513,16 @@ public class CausewayConfiguration {
             public static class Parameter {
 
                 /**
-                 * Whether dependent parameters should be reset to their default if an earlier parameter changes its
+                 * Whether parameters should be reset to their default if an earlier parameter changes its
                  * value, or whether instead a parameter value, once changed by the end-user, should never be
                  * overwritten even if the end-user changes an earlier parameter value.
                  *
                  * <p>
                  *     This setting can be overridden on a case-by-case basis using
-                 *     {@link org.apache.causeway.applib.annotation.Parameter#dependentDefaultsPolicy() Parameter#dependentDefaultsPolicy()}.
+                 *     {@link org.apache.causeway.applib.annotation.Parameter#precedingParamsPolicy() Parameter#precedingParametersPolicy()}.
                  * </p>
                  */
-                private ParameterConfigOptions.DependentDefaultsPolicy dependentDefaultsPolicy = ParameterConfigOptions.DependentDefaultsPolicy.UPDATE_DEPENDENT;
+                private ParameterConfigOptions.PrecedingParametersPolicy precedingParametersPolicy = ParameterConfigOptions.PrecedingParametersPolicy.RESET;
 
             }
 
diff --git a/core/config/src/main/java/org/apache/causeway/core/config/metamodel/facets/ParameterConfigOptions.java b/core/config/src/main/java/org/apache/causeway/core/config/metamodel/facets/ParameterConfigOptions.java
index bcc61a7c5a..e89331f9c1 100644
--- a/core/config/src/main/java/org/apache/causeway/core/config/metamodel/facets/ParameterConfigOptions.java
+++ b/core/config/src/main/java/org/apache/causeway/core/config/metamodel/facets/ParameterConfigOptions.java
@@ -24,29 +24,35 @@ import lombok.NonNull;
 
 public final class ParameterConfigOptions {
 
-    public static enum DependentDefaultsPolicy {
+    public enum PrecedingParametersPolicy {
         /**
          * Allows user provided parameters in the UI to be overwritten via defaults semantics.
          */
-        UPDATE_DEPENDENT,
+        RESET,
         /**
          * Forbids user provided parameters in the UI to be overwritten via defaults semantics.
+         *
+         * <P>
+         *     <b>WARNING</b>: If the parameter is constrained by dependent choices, then these will <i>not</i> be
+         *     re-evaluated.  The validation for the action should make sure that the parameter argument is validated
+         *     correctly.
+         * </P>
          */
         PRESERVE_CHANGES;
-        public boolean isUpdateDependent() { return this == UPDATE_DEPENDENT; }
+        public boolean isReset() { return this == RESET; }
         public boolean isPreserveChanges() { return this == PRESERVE_CHANGES; }
 
-        public static DependentDefaultsPolicy defaultsIfNotSpecifiedOtherwise() {
-            return UPDATE_DEPENDENT; // backwards compatibility
+        public static PrecedingParametersPolicy defaultsIfNotSpecifiedOtherwise() {
+            return RESET; // backwards compatibility
         }
     }
 
 
     // -- FACTORIES
 
-    public static DependentDefaultsPolicy dependentDefaultsPolicy(
+    public static PrecedingParametersPolicy precedingParametersPolicy(
             final @NonNull CausewayConfiguration configuration) {
-        return configuration.getApplib().getAnnotation().getParameter().getDependentDefaultsPolicy();
+        return configuration.getApplib().getAnnotation().getParameter().getPrecedingParametersPolicy();
     }
 
 
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/ParameterAnnotationFacetFactory.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/ParameterAnnotationFacetFactory.java
index 3e9a39b4a1..a91976fc09 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/ParameterAnnotationFacetFactory.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/ParameterAnnotationFacetFactory.java
@@ -54,7 +54,7 @@ extends FacetFactoryAbstract {
         processParamsFileAccept(processParameterContext);
     }
 
-    // check for @Parameter(dependentDefaultsPolicy=...)
+    // check for @Parameter(precedingParametersPolicy=...)
     void processParamsDependentDefaultsPolicy(final ProcessParameterContext processParameterContext) {
 
         val holder = processParameterContext.getFacetHolder();
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsActionFacetForActionAnnotationAsConfigured.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsActionFacetForActionAnnotationAsConfigured.java
index f37528a791..dbaf801666 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsActionFacetForActionAnnotationAsConfigured.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsActionFacetForActionAnnotationAsConfigured.java
@@ -26,7 +26,7 @@ public class ParameterDependentDefaultsActionFacetForActionAnnotationAsConfigure
 extends ParameterDependentDefaultsFacetForParameterAnnotation {
 
     ParameterDependentDefaultsActionFacetForActionAnnotationAsConfigured(
-            final ParameterConfigOptions.DependentDefaultsPolicy value, final FacetHolder holder) {
+            final ParameterConfigOptions.PrecedingParametersPolicy value, final FacetHolder holder) {
         super(value, holder);
     }
 
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacet.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacet.java
index 10d25a030c..e3f4a175a5 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacet.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacet.java
@@ -32,39 +32,39 @@ import org.apache.causeway.core.metamodel.facets.SingleValueFacet;
  * Determines how dependent parameter values should be updated,
  * if one of the earlier parameter values is changed.
  * <p>
- * Corresponds to annotating the action method {@link Parameter#dependentDefaultsPolicy()}.
+ * Corresponds to annotating the action method {@link Parameter#precedingParamsPolicy()}.
  *
  * @since 2.0
  */
 public interface ParameterDependentDefaultsFacet
-extends SingleValueFacet<ParameterConfigOptions.DependentDefaultsPolicy> {
+extends SingleValueFacet<ParameterConfigOptions.PrecedingParametersPolicy> {
 
     static Optional<ParameterDependentDefaultsFacet> create(
             final Optional<Parameter> parameterIfAny,
             final CausewayConfiguration configuration,
             final FacetHolder holder) {
 
-        final ParameterConfigOptions.DependentDefaultsPolicy defaultPolicyFromConfig =
-                ParameterConfigOptions.dependentDefaultsPolicy(configuration);
+        final ParameterConfigOptions.PrecedingParametersPolicy defaultPolicyFromConfig =
+                ParameterConfigOptions.precedingParametersPolicy(configuration);
 
         return _Optionals.orNullable(
 
         parameterIfAny
-        .map(Parameter::dependentDefaultsPolicy)
+        .map(Parameter::precedingParamsPolicy)
         .<ParameterDependentDefaultsFacet>map(policy -> {
             switch (policy) {
             case PRESERVE_CHANGES:
                 return new ParameterDependentDefaultsFacetForParameterAnnotation(
-                        ParameterConfigOptions.DependentDefaultsPolicy.PRESERVE_CHANGES, holder);
-            case UPDATE_DEPENDENT:
+                        ParameterConfigOptions.PrecedingParametersPolicy.PRESERVE_CHANGES, holder);
+            case RESET:
                 return new ParameterDependentDefaultsFacetForParameterAnnotation(
-                        ParameterConfigOptions.DependentDefaultsPolicy.UPDATE_DEPENDENT, holder);
+                        ParameterConfigOptions.PrecedingParametersPolicy.RESET, holder);
             case NOT_SPECIFIED:
             case AS_CONFIGURED:
                 return new ParameterDependentDefaultsFacetForParameterAnnotation(defaultPolicyFromConfig, holder);
             default:
             }
-            throw new IllegalStateException("dependentDefaultsPolicy '" + policy + "' not recognised");
+            throw new IllegalStateException("precedingParametersPolicy '" + policy + "' not recognised");
         })
         ,
         () -> new ParameterDependentDefaultsFacetFromConfiguration(defaultPolicyFromConfig, holder));
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetAbstract.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetAbstract.java
index b1fc623172..561199cc14 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetAbstract.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetAbstract.java
@@ -25,7 +25,7 @@ import org.apache.causeway.core.metamodel.facetapi.FacetHolder;
 import org.apache.causeway.core.metamodel.facets.SingleValueFacetAbstract;
 
 abstract class ParameterDependentDefaultsFacetAbstract
-extends SingleValueFacetAbstract<ParameterConfigOptions.DependentDefaultsPolicy>
+extends SingleValueFacetAbstract<ParameterConfigOptions.PrecedingParametersPolicy>
 implements ParameterDependentDefaultsFacet {
 
     private static final Class<? extends Facet> type() {
@@ -33,7 +33,7 @@ implements ParameterDependentDefaultsFacet {
     }
 
     protected ParameterDependentDefaultsFacetAbstract(
-            final ParameterConfigOptions.DependentDefaultsPolicy value, final FacetHolder holder) {
+            final ParameterConfigOptions.PrecedingParametersPolicy value, final FacetHolder holder) {
         super(type(), value, holder);
     }
 }
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetForParameterAnnotation.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetForParameterAnnotation.java
index 50161bf549..fcdc4b2adc 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetForParameterAnnotation.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetForParameterAnnotation.java
@@ -26,7 +26,7 @@ public class ParameterDependentDefaultsFacetForParameterAnnotation
 extends ParameterDependentDefaultsFacetAbstract {
 
     ParameterDependentDefaultsFacetForParameterAnnotation(
-            final ParameterConfigOptions.DependentDefaultsPolicy value, final FacetHolder holder) {
+            final ParameterConfigOptions.PrecedingParametersPolicy value, final FacetHolder holder) {
         super(value, holder);
     }
 
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetFromConfiguration.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetFromConfiguration.java
index 1f088d2ab9..9fedf5c862 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetFromConfiguration.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/facets/param/parameter/depdef/ParameterDependentDefaultsFacetFromConfiguration.java
@@ -26,7 +26,7 @@ public class ParameterDependentDefaultsFacetFromConfiguration
 extends ParameterDependentDefaultsFacetAbstract {
 
     ParameterDependentDefaultsFacetFromConfiguration(
-            final ParameterConfigOptions.DependentDefaultsPolicy value, final FacetHolder holder) {
+            final ParameterConfigOptions.PrecedingParametersPolicy value, final FacetHolder holder) {
         super(value, holder);
     }
 
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/spec/feature/ObjectActionParameter.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/spec/feature/ObjectActionParameter.java
index 5018eddc62..871b01717c 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/spec/feature/ObjectActionParameter.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/spec/feature/ObjectActionParameter.java
@@ -173,13 +173,13 @@ extends ObjectFeature, CurrentHolder {
      * whenever a parameter this one depends on changes in the UI. Parameters
      * with higher index depend on those with lower index.
      * <p>
-     * Reassessment can be switch off by means of {@link org.apache.causeway.applib.annotation.Parameter#dependentDefaultsPolicy()}.
+     * Reassessment can be switch off by means of {@link org.apache.causeway.applib.annotation.Parameter#precedingParamsPolicy()}.
      */
     default boolean reassessDefault(final ParameterNegotiationModel pendingArgs) {
         val changed = _Refs.booleanRef(false);
         val paramIndex = getParameterIndex();
         val bindableParamDirtyFlag = pendingArgs.getBindableParamValueDirtyFlag(paramIndex);
-        if(Facets.dependentDefaultsPolicy(this).isUpdateDependent()
+        if(Facets.dependentDefaultsPolicy(this).isReset()
                 // always allow when not dirtied by the user (UI)
                 || ! bindableParamDirtyFlag.getValue().booleanValue() ) {
             // reassess defaults honoring defaults semantics
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/util/Facets.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/util/Facets.java
index 35f3a29586..f8a6591e7f 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/util/Facets.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/util/Facets.java
@@ -175,11 +175,11 @@ public final class Facets {
         .map(DefaultViewFacet::value);
     }
 
-    public static ParameterConfigOptions.DependentDefaultsPolicy dependentDefaultsPolicy(
+    public static ParameterConfigOptions.PrecedingParametersPolicy dependentDefaultsPolicy(
             final ObjectActionParameter parameter) {
         return parameter.lookupFacet(ParameterDependentDefaultsFacet.class)
                 .map(ParameterDependentDefaultsFacet::value)
-                .orElseGet(ParameterConfigOptions.DependentDefaultsPolicy::defaultsIfNotSpecifiedOtherwise);
+                .orElseGet(ParameterConfigOptions.PrecedingParametersPolicy::defaultsIfNotSpecifiedOtherwise);
     }
 
     public boolean domainServiceIsPresent(final ObjectSpecification objectSpec) {
diff --git a/extensions/core/layoutloaders/github/src/main/java/org/apache/causeway/extensions/layoutloaders/github/menu/LayoutLoadersGitHubMenu.java b/extensions/core/layoutloaders/github/src/main/java/org/apache/causeway/extensions/layoutloaders/github/menu/LayoutLoadersGitHubMenu.java
index 5c34270344..29a0aa3d65 100644
--- a/extensions/core/layoutloaders/github/src/main/java/org/apache/causeway/extensions/layoutloaders/github/menu/LayoutLoadersGitHubMenu.java
+++ b/extensions/core/layoutloaders/github/src/main/java/org/apache/causeway/extensions/layoutloaders/github/menu/LayoutLoadersGitHubMenu.java
@@ -79,7 +79,7 @@ public class LayoutLoadersGitHubMenu {
             LayoutLoadersGitHubMenu.this.enabled = true;
         }
         @MemberSupport public boolean hideAct() {
-            return !isConfigured();
+            return isNotConfigured();
         }
         @MemberSupport public String disableAct() {
             return LayoutLoadersGitHubMenu.this.enabled ? "Already enabled" : null;
@@ -90,7 +90,7 @@ public class LayoutLoadersGitHubMenu {
 
     @Action(
             commandPublishing = Publishing.DISABLED,
-            domainEvent = enableDynamicLayoutLoading.ActionDomainEvent.class,
+            domainEvent = disableDynamicLayoutLoading.ActionDomainEvent.class,
             executionPublishing = Publishing.DISABLED,
             semantics = SemanticsOf.IDEMPOTENT
     )
@@ -106,17 +106,17 @@ public class LayoutLoadersGitHubMenu {
             LayoutLoadersGitHubMenu.this.enabled = false;
         }
         @MemberSupport public boolean hideAct() {
-            return !isConfigured();
+            return isNotConfigured();
         }
         @MemberSupport public String disableAct() {
             return LayoutLoadersGitHubMenu.this.enabled ? null : "Already disabled";
         }
     }
 
-    boolean isConfigured() {
+    boolean isNotConfigured() {
         val layoutLoadersGitHub = causewayConfiguration.getExtensions().getLayoutLoaders().getGithub();
-        return layoutLoadersGitHub.getRepository() != null &&
-               layoutLoadersGitHub.getApiKey() != null;
+        return layoutLoadersGitHub.getRepository() == null ||
+                layoutLoadersGitHub.getApiKey() == null;
     }
 
 }
diff --git a/extensions/vw/fullcalendar/applib/src/main/java/org/apache/causeway/extensions/fullcalendar/applib/value/CalendarEventSemantics.java b/extensions/vw/fullcalendar/applib/src/main/java/org/apache/causeway/extensions/fullcalendar/applib/value/CalendarEventSemantics.java
index a780ddf76a..4adde41059 100644
--- a/extensions/vw/fullcalendar/applib/src/main/java/org/apache/causeway/extensions/fullcalendar/applib/value/CalendarEventSemantics.java
+++ b/extensions/vw/fullcalendar/applib/src/main/java/org/apache/causeway/extensions/fullcalendar/applib/value/CalendarEventSemantics.java
@@ -34,7 +34,7 @@ import org.springframework.stereotype.Component;
 
 import org.apache.causeway.applib.annotation.Action;
 import org.apache.causeway.applib.annotation.ActionLayout;
-import org.apache.causeway.applib.annotation.DependentDefaultsPolicy;
+import org.apache.causeway.applib.annotation.PrecedingParamsPolicy;
 import org.apache.causeway.applib.annotation.MemberSupport;
 import org.apache.causeway.applib.annotation.Optionality;
 import org.apache.causeway.applib.annotation.Parameter;
@@ -253,16 +253,16 @@ implements
                 final LocalDateTime dateTime,
 
                 @Parameter(
-                        dependentDefaultsPolicy = DependentDefaultsPolicy.PRESERVE_CHANGES)
+                        precedingParamsPolicy = PrecedingParamsPolicy.PRESERVE_CHANGES)
                 final String calendarName,
 
                 @Parameter(
-                        dependentDefaultsPolicy = DependentDefaultsPolicy.PRESERVE_CHANGES)
+                        precedingParamsPolicy = PrecedingParamsPolicy.PRESERVE_CHANGES)
                 final String title,
 
                 @Parameter(
                         optionality = Optionality.OPTIONAL,
-                        dependentDefaultsPolicy = DependentDefaultsPolicy.PRESERVE_CHANGES)
+                        precedingParamsPolicy = PrecedingParamsPolicy.PRESERVE_CHANGES)
                 @ParameterLayout(multiLine = 4)
                 final String notes) {