You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/11/20 06:52:47 UTC
[PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
zhengruifeng opened a new pull request, #43904:
URL: https://github.com/apache/spark/pull/43904
### What changes were proposed in this pull request?
Restore apt-get/r installations for branch-3.3/3.4/3.5
### Why are the changes needed?
to restore daily builds for branch-3.3/3.4/3.5
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43904:
URL: https://github.com/apache/spark/pull/43904#issuecomment-1818355773
cc @LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43904:
URL: https://github.com/apache/spark/pull/43904#issuecomment-1818430457
> Is the maintenance cost high if these two patches are backported to branch-3.x?
I think so, BTW we already adopt such way to fix python linter:
```
- name: Install Python linter dependencies for branch-3.3
if: inputs.branch == 'branch-3.3'
run: ...
- name: Install Python linter dependencies for branch-3.4
if: inputs.branch == 'branch-3.4'
run: ...
- name: Install Python linter dependencies for branch-3.5
if: inputs.branch == 'branch-3.5'
run: ...
- name: Install Python linter dependencies
if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4' && inputs.branch != 'branch-3.5'
run: ...
- name: Python linter
run: PYTHON_EXECUTABLE=python3.9 ./dev/lint-python
- name: Install dependencies for Python code generation check
if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4'
run: ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43904:
URL: https://github.com/apache/spark/pull/43904#issuecomment-1818420644
This one is better, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43904:
URL: https://github.com/apache/spark/pull/43904#issuecomment-1818448719
> > Is the maintenance cost high if these two patches are backported to branch-3.x?
>
> I think so, BTW we already adopt such way to fix python linter:
>
> ```
> - name: Install Python linter dependencies for branch-3.3
> if: inputs.branch == 'branch-3.3'
> run: ...
> - name: Install Python linter dependencies for branch-3.4
> if: inputs.branch == 'branch-3.4'
> run: ...
> - name: Install Python linter dependencies for branch-3.5
> if: inputs.branch == 'branch-3.5'
> run: ...
> - name: Install Python linter dependencies
> if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4' && inputs.branch != 'branch-3.5'
> run: ...
> - name: Python linter
> run: PYTHON_EXECUTABLE=python3.9 ./dev/lint-python
> - name: Install dependencies for Python code generation check
> if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4'
> run: ...
> ```
OK, this pr is fine to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43904:
URL: https://github.com/apache/spark/pull/43904#issuecomment-1818409980
Is the maintenance cost high if these two patches are backported to branch-3.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43904:
URL: https://github.com/apache/spark/pull/43904#issuecomment-1818422162
Merged to master to recover the reported issues. Thank you, @LuciferYang and @zhengruifeng .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43904: [SPARK-45973][SPARK-45982][INFRA][FOLLOWUPS] Restore apt-get/r installations for branch-3.3/3.4/3.5
URL: https://github.com/apache/spark/pull/43904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org