You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2023/04/20 13:30:59 UTC

[GitHub] [cordova-cli] erisu opened a new pull request, #611: feat!(run): call platform api to list targets

erisu opened a new pull request, #611:
URL: https://github.com/apache/cordova-cli/pull/611

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   n/a
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Prepare for the removal of calling binaries in the platform packages.
   Use the platform API to handle listing out of targets.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   This PR requires changes in https://github.com/apache/cordova-lib/pull/917
   
   Since this breaking change needs the braking changes from the aboves Cordova-Lib PR, it is unessary to call the old method.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   `npm t`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-cli] erisu merged pull request #611: feat!(run): call platform api to list targets

Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #611:
URL: https://github.com/apache/cordova-cli/pull/611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org