You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/13 15:02:05 UTC

[GitHub] [apisix] Yiyiyimu commented on pull request #2390: fix: it does'nt make sence to compare etcd_version, since it's nil.

Yiyiyimu commented on pull request #2390:
URL: https://github.com/apache/apisix/pull/2390#issuecomment-707801650


   > @membphis BTW, I think bin/apisix should also be checked by luacheck, and then the little mistake like this undifinend var in comparasion expression will not happen. Only problem is the constraint of line length may be different now.
   
   That's a good idea! Actually tokers is fixing it in #2395. Welcome review~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org