You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Erick Erickson (Jira)" <ji...@apache.org> on 2020/09/23 01:24:00 UTC
[jira] [Commented] (SOLR-7520) Post filter
DelegatingCollector.finish not called for multi-shard queries specifying
grouping
[ https://issues.apache.org/jira/browse/SOLR-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200451#comment-17200451 ]
Erick Erickson commented on SOLR-7520:
--------------------------------------
These seem identical
> Post filter DelegatingCollector.finish not called for multi-shard queries specifying grouping
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-7520
> URL: https://issues.apache.org/jira/browse/SOLR-7520
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 4.8, 5.2.1
> Reporter: Eric Wheeler
> Priority: Major
> Attachments: SolrGroupTest-5.2.1.tgz, solrGroupTestEx.tgz
>
>
> The finish method for a DelegatingCollector post filter is not being called for queries specifying a fq filter, multiple shards, and grouping options.
> Recommend adding the following code to org.apache.solr.search.grouping.CommandHandler.searchWithTimeLimiter to call finish (if a DelegatingCollector is available) after calling search, but before obtaining totalHitCount:
> {code: title=org.apache.solr.search.grouping.CommandHandler line ~218}
> try {
> searcher.search(query, luceneFilter, collector);
> } catch (TimeLimitingCollector.TimeExceededException x) {
> partialResults = true;
> logger.warn( "Query: " + query + "; " + x.getMessage() );
> }
> /* Call finish of DelegatingCollector to complete post processing
> for multi-shard queries */
> if (filter.postFilter != null) {
> filter.postFilter.finish();
> }
> /* END: Call finish of DelegatingCollector to complete post processing
> for multi-shard queries */
> if (includeHitCount) {
> totalHitCount = hitCountCollector.getTotalHits();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org