[impala] 01/02: IMPALA-10267: Addendum (Properly handle continued scanning after parse error in HdfsAvroScanner)

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit ee9238a864cb849db7f166b7cb82292aa17c6dcd
Author: Daniel Becker <da...@cloudera.com>
AuthorDate: Thu Jul 21 13:49:26 2022 +0200

    IMPALA-10267: Addendum
    (Properly handle continued scanning after parse error in
    HdfsAvroScanner)
    
    The commit for IMPALA-10267 contained an error: in
    hdfs-avro-scanner.cc:514 the condition checked the num_records_in_block_
    member variable instead of the num_records_in_block local variable. This
    way the error described in IMPALA-10267 was not corrected.
    
    This commit fixes this error.
    
    Change-Id: I81e12e43c776f6eaa8a2803ea87e98093a98c2b7
    Reviewed-on: http://gerrit.cloudera.org:8080/18767
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/exec/hdfs-avro-scanner.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/exec/hdfs-avro-scanner.cc b/be/src/exec/hdfs-avro-scanner.cc
index a8fa737ef..3cd20ba6e 100644
--- a/be/src/exec/hdfs-avro-scanner.cc
+++ b/be/src/exec/hdfs-avro-scanner.cc
@@ -511,7 +511,7 @@ Status HdfsAvroScanner::ProcessRange(RowBatch* row_batch) {
       data_block_end_ = nullptr;
       int64_t num_records_in_block;
       RETURN_IF_FALSE(stream_->ReadZLong(&num_records_in_block, &parse_status_));
-      if (num_records_in_block_ < 0) {
+      if (num_records_in_block < 0) {
         return Status(TErrorCode::AVRO_INVALID_RECORD_COUNT, stream_->filename(),
             num_records_in_block_, stream_->file_offset());
       }