You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/10/11 18:02:57 UTC

[GitHub] [netbeans] entlicher opened a new pull request #3235: The class com.oracle.truffle.polyglot.LanguageCache$Loader is not found in newer GraalVMs, use TruffleJDKServices instead.

entlicher opened a new pull request #3235:
URL: https://github.com/apache/netbeans/pull/3235


   The `LanguageCache$Loader` class has disappeared In GraalVM 21.3. We need to adapt our implementation and use an existing `TruffleJDKServices` instead, which is available in older GraalVMs as well.
   
   I've already started plans for integration tests of NetBeans debugger with the latest GraalVM to prevent from situations like this in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] entlicher commented on a change in pull request #3235: The class com.oracle.truffle.polyglot.LanguageCache$Loader is not found in newer GraalVMs, use TruffleJDKServices instead.

Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #3235:
URL: https://github.com/apache/netbeans/pull/3235#discussion_r726916608



##########
File path: java/debugger.jpda.truffle/src/org/netbeans/modules/debugger/jpda/truffle/RemoteServices.java
##########
@@ -95,17 +95,17 @@
     
     private static final Logger logger = Logger.getLogger(RemoteServices.class.getName());
     
-    static final String REMOTE_CLASSES_ZIPFILE = "/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";
+    static final String REMOTE_CLASSES_ZIPFILE = "/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";    // NOI18N
 
-    private static final String TRUFFLE_CLASS = "com.oracle.truffle.api.Truffle";
-    private static final String EXPORT_TRUFFLE_CLASS = "com.oracle.truffle.polyglot.LanguageCache$Loader";
-    private static final String EXPORT_TRUFFLE_METHOD = "exportTruffle";
-    private static final String EXPORT_TRUFFLE_SIGNAT = "(Ljava/lang/ClassLoader;)V";
+    private static final String TRUFFLE_CLASS = "com.oracle.truffle.api.Truffle";       // NOI18N

Review comment:
       This class and the method exists in the older versions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3235: The class com.oracle.truffle.polyglot.LanguageCache$Loader is not found in newer GraalVMs, use TruffleJDKServices instead.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3235:
URL: https://github.com/apache/netbeans/pull/3235#discussion_r726750151



##########
File path: java/debugger.jpda.truffle/src/org/netbeans/modules/debugger/jpda/truffle/RemoteServices.java
##########
@@ -95,17 +95,17 @@
     
     private static final Logger logger = Logger.getLogger(RemoteServices.class.getName());
     
-    static final String REMOTE_CLASSES_ZIPFILE = "/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";
+    static final String REMOTE_CLASSES_ZIPFILE = "/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";    // NOI18N
 
-    private static final String TRUFFLE_CLASS = "com.oracle.truffle.api.Truffle";
-    private static final String EXPORT_TRUFFLE_CLASS = "com.oracle.truffle.polyglot.LanguageCache$Loader";
-    private static final String EXPORT_TRUFFLE_METHOD = "exportTruffle";
-    private static final String EXPORT_TRUFFLE_SIGNAT = "(Ljava/lang/ClassLoader;)V";
+    private static final String TRUFFLE_CLASS = "com.oracle.truffle.api.Truffle";       // NOI18N

Review comment:
       Shouldn't we be searching for both classes in order to run on old and new GraalVM?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] entlicher merged pull request #3235: The class com.oracle.truffle.polyglot.LanguageCache$Loader is not found in newer GraalVMs, use TruffleJDKServices instead.

Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #3235:
URL: https://github.com/apache/netbeans/pull/3235


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] entlicher commented on a change in pull request #3235: The class com.oracle.truffle.polyglot.LanguageCache$Loader is not found in newer GraalVMs, use TruffleJDKServices instead.

Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #3235:
URL: https://github.com/apache/netbeans/pull/3235#discussion_r726921051



##########
File path: java/debugger.jpda.truffle/src/org/netbeans/modules/debugger/jpda/truffle/RemoteServices.java
##########
@@ -95,17 +95,17 @@
     
     private static final Logger logger = Logger.getLogger(RemoteServices.class.getName());
     
-    static final String REMOTE_CLASSES_ZIPFILE = "/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";
+    static final String REMOTE_CLASSES_ZIPFILE = "/org/netbeans/modules/debugger/jpda/truffle/resources/JPDATruffleBackend.jar";    // NOI18N
 
-    private static final String TRUFFLE_CLASS = "com.oracle.truffle.api.Truffle";
-    private static final String EXPORT_TRUFFLE_CLASS = "com.oracle.truffle.polyglot.LanguageCache$Loader";
-    private static final String EXPORT_TRUFFLE_METHOD = "exportTruffle";
-    private static final String EXPORT_TRUFFLE_SIGNAT = "(Ljava/lang/ClassLoader;)V";
+    private static final String TRUFFLE_CLASS = "com.oracle.truffle.api.Truffle";       // NOI18N

Review comment:
       It's certainly good to test the released GraalVM and we should improve our current tests, but GraalVM integration tests can also be extended with NB-specific tests to catch possible issues early and assure compatibility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists