You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/23 08:47:22 UTC
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4304: [INLONG-4303][Sort] Iceberg Load Node add required option
yunqingmoswu commented on code in PR #4304:
URL: https://github.com/apache/incubator-inlong/pull/4304#discussion_r879180327
##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/IcebergNodeSqlParserTest.java:
##########
@@ -111,14 +121,21 @@ private IcebergLoadNode buildIcebergLoadNodeWithHiveCatalog() {
);
// set HIVE_CONF_DIR,or set uri and warehouse
- Map<String, String> props = new HashMap<>();
- props.put("catalog-type", "hive");
- props.put("catalog-name", "hive_prod");
- props.put("catalog-database", "default");
- props.put("uri", "thrift://localhost:9083");
- props.put("warehouse", "/hive/warehouse");
- IcebergLoadNode node = new IcebergLoadNode("iceberg", "iceberg_output", fields, relations,
- null, null, null, props, "inlong", "inlong_iceberg");
+ IcebergLoadNode node = new IcebergLoadNode(
Review Comment:
Is it necessary to define the node variable here?
##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/IcebergNodeSqlParserTest.java:
##########
@@ -85,12 +86,21 @@ private IcebergLoadNode buildIcebergLoadNodeWithHadoopCatalog() {
new FieldInfo("ts", new TimestampFormatInfo()))
);
- Map<String, String> props = new HashMap<>();
- props.put("catalog-type", "hadoop");
- props.put("catalog-name", "hadoop_prod");
- props.put("warehouse", "hdfs://localhost:9000/iceberg/warehouse");
- IcebergLoadNode node = new IcebergLoadNode("iceberg", "iceberg_output", fields, relations,
- null, null, null, props, "inlong", "inlong_iceberg");
+ IcebergLoadNode node = new IcebergLoadNode(
Review Comment:
Is it necessary to define the node variable here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org