You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jiangzzhu (via GitHub)" <gi...@apache.org> on 2026/09/23 17:12:48 UTC
[PR] [release-2.77] [Spanner Change Streams] Leave tracker at last claimed position instead of artificial query end timestamp [beam]
jiangzzhu opened a new pull request, #40247:
URL: https://github.com/apache/beam/pull/40247
Cherry-pick of #40209 into `release-2.77` (fixes #40232).
When a Spanner change stream query finishes without emitting a `ChildPartitionsRecord` for a rare corner case, advancing the restriction tracker to the artificial `changeStreamQueryEndTimestamp` (`now + 2 minutes`) can skip past the partition's end timestamp and cause `QueryChangeStreamAction` to mark the partition `FINISHED` before scheduling its child partitions.
This change leaves the restriction tracker at the last claimed position (record or heartbeat) instead of advancing to `changeStreamQueryEndTimestamp` when resuming (`!stopAfterQuerySucceeds`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [release-2.77] [Spanner Change Streams] Leave tracker at last claimed position instead of artificial query end timestamp [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40247:
URL: https://github.com/apache/beam/pull/40247#issuecomment-5801253439
Assigning reviewers:
R: @kennknowles for label java.
R: @nielm for label spanner.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [release-2.77] [Spanner Change Streams] Leave tracker at last claimed position instead of artificial query end timestamp [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #40247:
URL: https://github.com/apache/beam/pull/40247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [release-2.77] [Spanner Change Streams] Leave tracker at last claimed position instead of artificial query end timestamp [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #40247:
URL: https://github.com/apache/beam/pull/40247#issuecomment-5800080648
LGTM - will wait for CI results to confirm green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org