[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2009: HDDS-4916. No ACL check when uploading object through multi-upload.

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #2009:
URL: https://github.com/apache/ozone/pull/2009#discussion_r594544563



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java
##########
@@ -126,7 +128,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       multipartKey = omMetadataManager.getMultipartKey(volumeName,
           bucketName, keyName, uploadID);
 
-      // TODO to support S3 ACL later.
+      // check Acl
+      checkKeyAcls(ozoneManager, volumeName, bucketName, keyName,
+          IAccessAuthorizer.ACLType.WRITE, OzoneObj.ResourceType.KEY);

Review comment:
       Should we check for CREATE as we are completing the key write by adding new entry in the KeyTable? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org