You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2025/11/06 02:28:39 UTC
[PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
aminghadersohi opened a new pull request, #36013:
URL: https://github.com/apache/superset/pull/36013
### SUMMARY
This PR fixes two critical bugs and enhances documentation in the MCP service:
1. **Flask App Context Error** - Fixes `health_check` tool failing in deployment with "Working outside of application context" error
2. **Pydantic Warning** - Resolves warning about `schema` field shadowing BaseModel attribute
3. **Auth Documentation** - Replaces TODO comments with production-ready deployment guidance
**Context:**
The `health_check` tool was the only MCP tool that doesn't access Flask functionality directly. In stateless HTTP mode, the `@mcp_auth_hook` decorator attempted to access `current_app.config` without ensuring Flask app context was active, causing failures in deployment environments while working fine locally.
### CHANGES
#### 1. Flask App Context Fix (`superset/mcp_service/auth.py`)
**Problem:**
- `health_check` tool failed in deployment with "Working outside of application context"
- Root cause: `mcp_auth_hook` called `current_app.config` without active Flask context
- Only affected tools that don't access Flask functionality in their implementation
**Solution:**
```python
@functools.wraps(tool_func)
def wrapper(*args: Any, **kwargs: Any) -> Any:
from superset.mcp_service.flask_singleton import get_flask_app
app = get_flask_app()
# Explicitly push Flask app context for stateless_http mode
with app.app_context():
user = get_user_from_request()
g.user = user
# ... tool execution
```
**Impact:**
- Ensures all MCP tools have guaranteed Flask app context
- Critical for `stateless_http=True` mode in production
- Makes auth system more robust and predictable
#### 2. Pydantic Warning Fix (`superset/mcp_service/common/error_schemas.py`)
**Problem:**
```
UserWarning: Field name "schema" in "DatasetContext" shadows an attribute in parent "BaseModel"
```
**Solution:**
```python
class DatasetContext(BaseModel):
model_config = {"populate_by_name": True}
schema_name: str | None = Field(None, alias="schema", description="Schema name")
```
**Impact:**
- Eliminates Pydantic v2 warning
- Maintains backward compatibility (accepts both `schema` and `schema_name`)
- Follows Pydantic best practices
#### 3. Enhanced Auth Documentation (`superset/mcp_service/auth.py`)
**Changes:**
- Removed all TODO comments suggesting "future PR" work
- Added comprehensive deployment guidance with concrete examples
- Clarified hook pattern as production-ready extension point
- Provided actionable code examples for:
- JWT authentication integration
- Custom permission checks
- Audit logging implementation
- Rate limiting middleware
**Impact:**
- Deployers have clear guidance for production customization
- Emphasizes MCP auth is a flexible hook system, not incomplete code
- Reduces confusion about auth implementation status
### TESTING
✅ All 178 MCP service unit tests pass
✅ Pre-commit checks pass (mypy, ruff, pylint)
✅ No Pydantic warnings when importing MCP service
✅ Backward compatibility verified for `DatasetContext` usage
### BEFORE/AFTER
**Before:**
- `health_check` tool fails in deployment with Flask context error
- Pydantic warning appears on every MCP service import
- TODO comments suggest auth system is incomplete
**After:**
- All MCP tools work reliably in stateless HTTP mode
- No Pydantic warnings
- Clear production deployment guidance
### ADDITIONAL INFORMATION
- [ ] Has associated issue: N/A (bug fix)
- [ ] Required feature flags: None
- [x] Changes UI: No
- [ ] Includes DB Migration: No
- [ ] Introduces new feature or API: No
- [ ] Removes existing feature or API: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #36013:
URL: https://github.com/apache/superset/pull/36013#discussion_r2499569737
##########
superset/mcp_service/auth.py:
##########
@@ -119,61 +154,92 @@ def mcp_auth_hook(tool_func: F) -> F:
"""
Authentication and authorization decorator for MCP tools.
- This is a minimal implementation that:
- 1. Gets the current user
- 2. Sets g.user for Flask context
-
- TODO (future PR): Add permission checking
- TODO (future PR): Add JWT scope validation
- TODO (future PR): Add comprehensive audit logging
- TODO (future PR): Add rate limiting integration
+ This hook ensures proper Flask app context and user authentication for all
+ MCP tool calls. Deployers can extend this decorator to add:
+
+ - Permission checks: Validate user has specific roles or tool access rights
+ - JWT scope validation: Check OAuth scopes match required tool permissions
+ - Audit logging: Track tool usage, parameters, and results for compliance
+ - Rate limiting: Enforce per-user or per-tool rate limits
+ - Custom middleware: Inject organization-specific security policies
+
+ Default behavior:
+ 1. Ensures Flask app context is active (critical for stateless_http mode)
+ 2. Authenticates user via get_user_from_request()
+ 3. Sets g.user for Superset's security manager integration
+ 4. Manages database session lifecycle
+
+ Example extensions:
+ # Add permission check before tool execution:
+ if tool_func.__name__ in ['execute_sql'] and not user.is_admin():
+ raise PermissionError("SQL execution requires admin role")
+
+ # Add audit logging after successful execution:
+ audit_log.info({
+ 'user': user.username,
+ 'tool': tool_func.__name__,
+ 'timestamp': datetime.now(),
+ 'result': 'success'
+ })
"""
import functools
@functools.wraps(tool_func)
def wrapper(*args: Any, **kwargs: Any) -> Any:
from superset.extensions import db
+ from superset.mcp_service.flask_singleton import get_flask_app
- # Get user and set Flask context OUTSIDE try block
- user = get_user_from_request()
+ # Get Flask app instance
+ app = get_flask_app()
- # Force load relationships NOW while session is definitely active
- _ = user.roles
- if hasattr(user, "groups"):
- _ = user.groups
+ # Ensure Flask app context is active
+ # This is critical for stateless_http mode where context isn't preserved
+ with app.app_context():
+ # Get user and set Flask context OUTSIDE try block
+ user = get_user_from_request()
- g.user = user
+ # Force load relationships NOW while session is definitely active
+ _ = user.roles
+ if hasattr(user, "groups"):
+ _ = user.groups
- try:
- # TODO: Add permission checks here in future PR
- # TODO: Add audit logging here in future PR
+ g.user = user
- logger.debug(
- "MCP tool call: user=%s, tool=%s", user.username, tool_func.__name__
- )
+ try:
+ # Deployers: Add custom permission checks here
+ # Example: Check tool-specific permissions, validate JWT scopes,
+ # or enforce organizational policies
- result = tool_func(*args, **kwargs)
+ logger.debug(
+ "MCP tool call: user=%s, tool=%s", user.username, tool_func.__name__
+ )
- return result
+ result = tool_func(*args, **kwargs)
- except Exception:
- # On error, rollback and cleanup session
- # pylint: disable=consider-using-transaction
- try:
- db.session.rollback()
- db.session.remove()
- except Exception as e:
- logger.warning("Error cleaning up session after exception: %s", e)
- raise
-
- finally:
- # Only rollback if session is still active (no exception occurred)
- # Do NOT call remove() on success to avoid detaching user
- try:
- if db.session.is_active:
- # pylint: disable=consider-using-transaction
+ # Deployers: Add audit logging or post-execution hooks here
+ # Example: Log successful tool execution, track metrics,
+ # or trigger downstream workflows
+
+ return result
+
+ except Exception:
+ # On error, rollback and cleanup session
+ # pylint: disable=consider-using-transaction
+ try:
db.session.rollback()
- except Exception as e:
- logger.warning("Error in finally block: %s", e)
+ db.session.remove()
+ except Exception as e:
+ logger.warning("Error cleaning up session after exception: %s", e)
Review Comment:
Do we need both the warning and the raised error in the logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #36013:
URL: https://github.com/apache/superset/pull/36013#discussion_r2496867344
##########
superset/mcp_service/common/error_schemas.py:
##########
@@ -48,9 +48,11 @@ class ValidationError(BaseModel):
class DatasetContext(BaseModel):
"""Dataset information for error context"""
+ model_config = {"populate_by_name": True}
+
id: int = Field(..., description="Dataset ID")
table_name: str = Field(..., description="Table name")
- schema: str | None = Field(None, description="Schema name")
+ schema_name: str | None = Field(None, alias="schema", description="Schema name")
Review Comment:
### Incomplete alias configuration for schema field <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The field aliasing configuration may not work as expected without proper model configuration for backward compatibility.
###### Why this matters
While `populate_by_name` is set to True, this only allows population by field name. The alias 'schema' might not be properly handled during serialization, potentially breaking existing code that expects the field to be serialized as 'schema' rather than 'schema_name'.
###### Suggested change ∙ *Feature Preview*
Add `serialization_alias` to ensure the field is serialized with the expected name:
```python
schema_name: str | None = Field(
None,
alias="schema",
serialization_alias="schema",
description="Schema name"
)
```
Or use `AliasChoices` for more robust handling:
```python
from pydantic import AliasChoices
schema_name: str | None = Field(
None,
validation_alias=AliasChoices("schema", "schema_name"),
serialization_alias="schema",
description="Schema name"
)
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a461dc14-a353-4e8d-8949-d854c1e87fe6/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a461dc14-a353-4e8d-8949-d854c1e87fe6?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a461dc14-a353-4e8d-8949-d854c1e87fe6?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a461dc14-a353-4e8d-8949-d854c1e87fe6?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a461dc14-a353-4e8d-8949-d854c1e87fe6)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:0dedeb72-b11c-46ab-a348-40641702bf03 -->
[](0dedeb72-b11c-46ab-a348-40641702bf03)
##########
superset/mcp_service/auth.py:
##########
@@ -119,61 +154,92 @@ def mcp_auth_hook(tool_func: F) -> F:
"""
Authentication and authorization decorator for MCP tools.
- This is a minimal implementation that:
- 1. Gets the current user
- 2. Sets g.user for Flask context
-
- TODO (future PR): Add permission checking
- TODO (future PR): Add JWT scope validation
- TODO (future PR): Add comprehensive audit logging
- TODO (future PR): Add rate limiting integration
+ This hook ensures proper Flask app context and user authentication for all
+ MCP tool calls. Deployers can extend this decorator to add:
+
+ - Permission checks: Validate user has specific roles or tool access rights
+ - JWT scope validation: Check OAuth scopes match required tool permissions
+ - Audit logging: Track tool usage, parameters, and results for compliance
+ - Rate limiting: Enforce per-user or per-tool rate limits
+ - Custom middleware: Inject organization-specific security policies
+
+ Default behavior:
+ 1. Ensures Flask app context is active (critical for stateless_http mode)
+ 2. Authenticates user via get_user_from_request()
+ 3. Sets g.user for Superset's security manager integration
+ 4. Manages database session lifecycle
+
+ Example extensions:
+ # Add permission check before tool execution:
+ if tool_func.__name__ in ['execute_sql'] and not user.is_admin():
+ raise PermissionError("SQL execution requires admin role")
+
+ # Add audit logging after successful execution:
+ audit_log.info({
+ 'user': user.username,
+ 'tool': tool_func.__name__,
+ 'timestamp': datetime.now(),
+ 'result': 'success'
+ })
"""
import functools
@functools.wraps(tool_func)
def wrapper(*args: Any, **kwargs: Any) -> Any:
from superset.extensions import db
+ from superset.mcp_service.flask_singleton import get_flask_app
- # Get user and set Flask context OUTSIDE try block
- user = get_user_from_request()
+ # Get Flask app instance
+ app = get_flask_app()
- # Force load relationships NOW while session is definitely active
- _ = user.roles
- if hasattr(user, "groups"):
- _ = user.groups
+ # Ensure Flask app context is active
+ # This is critical for stateless_http mode where context isn't preserved
+ with app.app_context():
+ # Get user and set Flask context OUTSIDE try block
+ user = get_user_from_request()
- g.user = user
+ # Force load relationships NOW while session is definitely active
+ _ = user.roles
+ if hasattr(user, "groups"):
+ _ = user.groups
Review Comment:
### Unnecessary eager loading of user relationships <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Eager loading of user relationships on every tool call regardless of whether they are needed by the specific tool.
###### Why this matters
This forces loading of potentially large relationship collections (roles, groups) even when tools don't require this data, wasting memory and database bandwidth.
###### Suggested change ∙ *Feature Preview*
Load relationships lazily or only when needed by specific tools. Consider adding a parameter to control relationship loading:
```python
def get_user_from_request(load_relationships: bool = False) -> User:
user = db.session.query(User).filter(User.username == username).first()
if load_relationships:
# Only load when explicitly requested
_ = user.roles
if hasattr(user, "groups"):
_ = user.groups
return user
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f55dc8aa-c38a-41ad-9119-7e514359a9a2/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f55dc8aa-c38a-41ad-9119-7e514359a9a2?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f55dc8aa-c38a-41ad-9119-7e514359a9a2?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f55dc8aa-c38a-41ad-9119-7e514359a9a2?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f55dc8aa-c38a-41ad-9119-7e514359a9a2)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:73a2e9d1-60d0-41df-a4b2-bc21c036015b -->
[](73a2e9d1-60d0-41df-a4b2-bc21c036015b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36013:
URL: https://github.com/apache/superset/pull/36013#issuecomment-3494576709
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #36013:
URL: https://github.com/apache/superset/pull/36013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #36013:
URL: https://github.com/apache/superset/pull/36013#issuecomment-3499068729
I've addressed the reviewer feedback with the latest commit:
## Changes Made
### 1. Replaced `_` Variable Names (@eschutho)
- Changed `_ = user.roles` to `user_roles = user.roles # noqa: F841`
- Changed `_ = user.groups` to `user_groups = user.groups # noqa: F841`
- This avoids confusion with the translation function `_()` commonly used in Superset
- Added `noqa: F841` because these variables are intentionally unused (they trigger eager loading)
### 2. Fixed Pydantic Alias Configuration (@korbit-ai)
- Added `serialization_alias="schema"` to `DatasetContext.schema_name` field
- This ensures the field serializes correctly as `"schema"` in output, not `"schema_name"`
- The field can now accept input as either `"schema"` or `"schema_name"` (via `alias`)
### 3. Improved Exception Handling Comments (@eschutho)
- Added clarifying comments to explain why we log cleanup errors but re-raise the original exception
- Renamed `e` to `cleanup_error` for clarity
- The pattern preserves the original tool error while logging any session cleanup failures
### About the Performance Concern (@korbit-ai)
The eager loading of user relationships (`user.roles`, `user.groups`) is **intentional** and necessary in this context:
- **Why**: SQLAlchemy sessions close after the tool execution, causing lazy-loading errors
- **When**: Only happens once per tool call, not repeatedly
- **Cost**: Minimal - two simple relationship queries per request
- **Benefit**: Prevents runtime errors when accessing user permissions later
This is a session lifecycle management pattern, not a performance issue. The relationships are needed by Superset's security layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #36013:
URL: https://github.com/apache/superset/pull/36013#discussion_r2499562130
##########
superset/mcp_service/auth.py:
##########
@@ -119,61 +154,92 @@ def mcp_auth_hook(tool_func: F) -> F:
"""
Authentication and authorization decorator for MCP tools.
- This is a minimal implementation that:
- 1. Gets the current user
- 2. Sets g.user for Flask context
-
- TODO (future PR): Add permission checking
- TODO (future PR): Add JWT scope validation
- TODO (future PR): Add comprehensive audit logging
- TODO (future PR): Add rate limiting integration
+ This hook ensures proper Flask app context and user authentication for all
+ MCP tool calls. Deployers can extend this decorator to add:
+
+ - Permission checks: Validate user has specific roles or tool access rights
+ - JWT scope validation: Check OAuth scopes match required tool permissions
+ - Audit logging: Track tool usage, parameters, and results for compliance
+ - Rate limiting: Enforce per-user or per-tool rate limits
+ - Custom middleware: Inject organization-specific security policies
+
+ Default behavior:
+ 1. Ensures Flask app context is active (critical for stateless_http mode)
+ 2. Authenticates user via get_user_from_request()
+ 3. Sets g.user for Superset's security manager integration
+ 4. Manages database session lifecycle
+
+ Example extensions:
+ # Add permission check before tool execution:
+ if tool_func.__name__ in ['execute_sql'] and not user.is_admin():
+ raise PermissionError("SQL execution requires admin role")
+
+ # Add audit logging after successful execution:
+ audit_log.info({
+ 'user': user.username,
+ 'tool': tool_func.__name__,
+ 'timestamp': datetime.now(),
+ 'result': 'success'
+ })
"""
import functools
@functools.wraps(tool_func)
def wrapper(*args: Any, **kwargs: Any) -> Any:
from superset.extensions import db
+ from superset.mcp_service.flask_singleton import get_flask_app
- # Get user and set Flask context OUTSIDE try block
- user = get_user_from_request()
+ # Get Flask app instance
+ app = get_flask_app()
- # Force load relationships NOW while session is definitely active
- _ = user.roles
- if hasattr(user, "groups"):
- _ = user.groups
+ # Ensure Flask app context is active
+ # This is critical for stateless_http mode where context isn't preserved
+ with app.app_context():
+ # Get user and set Flask context OUTSIDE try block
+ user = get_user_from_request()
- g.user = user
+ # Force load relationships NOW while session is definitely active
+ _ = user.roles
Review Comment:
I'd be somewhat cautious about using _ as a variable name because it's usually used for the translation function in Superset. Could be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp-service): ensure Flask app context in auth hook and resolve Pydantic warnings [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36013:
URL: https://github.com/apache/superset/pull/36013#issuecomment-3494593023
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/36013?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `25 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.47%. Comparing base ([`1f960d5`](https://app.codecov.io/gh/apache/superset/commit/1f960d5761f31d3cac2697a988b64ba08b2d980b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`79bf966`](https://app.codecov.io/gh/apache/superset/commit/79bf9664fae2268626ffb44d8f056b8940cf4c0d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/36013?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/mcp\_service/auth.py](https://app.codecov.io/gh/apache/superset/pull/36013?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fauth.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvYXV0aC5weQ==) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/36013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/mcp\_service/common/error\_schemas.py](https://app.codecov.io/gh/apache/superset/pull/36013?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fcommon%2Ferror_schemas.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY29tbW9uL2Vycm9yX3NjaGVtYXMucHk=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/36013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36013 +/- ##
===========================================
+ Coverage 0 48.47% +48.47%
===========================================
Files 0 622 +622
Lines 0 45722 +45722
Branches 0 4975 +4975
===========================================
+ Hits 0 22165 +22165
- Misses 0 22932 +22932
- Partials 0 625 +625
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/36013/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/36013/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.20% <0.00%> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/36013/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.76% <0.00%> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/36013/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <0.00%> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/36013/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/36013?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org