You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/15 05:52:53 UTC

[GitHub] [flink] rmetzger opened a new pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

rmetzger opened a new pull request #13390:
URL: https://github.com/apache/flink/pull/13390


   ## What is the purpose of the change
   
   Before this change, the dispatcher was using the executor of the RPC service for executing IO or heavy tasks.
   Now, we forward the ioExecutor of the ClusterEntrypoint to the Dispatcher.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13390:
URL: https://github.com/apache/flink/pull/13390#issuecomment-692649215


   Thanks for the review. Will merge the change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13390:
URL: https://github.com/apache/flink/pull/13390#issuecomment-692489521


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd16dde2164920786908bee57d113c918fc3abca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fd16dde2164920786908bee57d113c918fc3abca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd16dde2164920786908bee57d113c918fc3abca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger closed pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13390:
URL: https://github.com/apache/flink/pull/13390


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13390:
URL: https://github.com/apache/flink/pull/13390#issuecomment-692489521


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd16dde2164920786908bee57d113c918fc3abca",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6510",
       "triggerID" : "fd16dde2164920786908bee57d113c918fc3abca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd16dde2164920786908bee57d113c918fc3abca Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6510) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13390:
URL: https://github.com/apache/flink/pull/13390#discussion_r488581148



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/PartialDispatcherServicesWithJobGraphStore.java
##########
@@ -81,6 +85,8 @@ public static PartialDispatcherServicesWithJobGraphStore from(PartialDispatcherS
 			partialDispatcherServices.getFatalErrorHandler(),
 			partialDispatcherServices.getHistoryServerArchivist(),
 			partialDispatcherServices.getMetricQueryServiceAddress(),
+			partialDispatcherServices.getIoExecutor(),
 			jobGraphWriter);
 	}
+

Review comment:
       revert




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13390:
URL: https://github.com/apache/flink/pull/13390#issuecomment-692489521


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fd16dde2164920786908bee57d113c918fc3abca",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6510",
       "triggerID" : "fd16dde2164920786908bee57d113c918fc3abca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fd16dde2164920786908bee57d113c918fc3abca Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6510) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13390: [FLINK-19037] Forward ioExecutor from ClusterEntrypoint to Dispatcher

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13390:
URL: https://github.com/apache/flink/pull/13390#issuecomment-692482079


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit fd16dde2164920786908bee57d113c918fc3abca (Tue Sep 15 05:54:27 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org