You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/25 01:00:45 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7531: [AIRFLOW-6910]
Fix kill_zombie method call
mik-laj opened a new pull request #7531: [AIRFLOW-6910] Fix kill_zombie method call
URL: https://github.com/apache/airflow/pull/7531
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Fokko merged pull request #7531: [AIRFLOW-6910] Fix
kill_zombie method call
Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #7531: [AIRFLOW-6910] Fix kill_zombie method call
URL: https://github.com/apache/airflow/pull/7531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Fokko commented on issue #7531: [AIRFLOW-6910] Fix
kill_zombie method call
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #7531: [AIRFLOW-6910] Fix kill_zombie method call
URL: https://github.com/apache/airflow/pull/7531#issuecomment-590871285
Thanks @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7531: [AIRFLOW-6910] Fix
kill_zombie method call
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7531: [AIRFLOW-6910] Fix kill_zombie method call
URL: https://github.com/apache/airflow/pull/7531#issuecomment-590880959
@mik-laj @Fokko In situations like this can we please get in to the habit of targeting the bug fix at the same Jira issue as the original breaking change -- that way if we ever need to backport it we get the change _and_ the fix. Two jiras means the fix is likely to get missed.
(Plus right now one PR = one Jira is just busy work, if we're going to do this lets just stop using Jira)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7531: [AIRFLOW-6910] Fix
kill_zombie method call
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7531: [AIRFLOW-6910] Fix kill_zombie method call
URL: https://github.com/apache/airflow/pull/7531#issuecomment-590645698
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7531?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d1a3424`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7531?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7531 +/- ##
=========================================
Coverage ? 86.23%
=========================================
Files ? 896
Lines ? 42638
Branches ? 0
=========================================
Hits ? 36768
Misses ? 5870
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7531?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7531/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `87.69% <100%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7531?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7531?src=pr&el=footer). Last update [d1a3424...9933afe](https://codecov.io/gh/apache/airflow/pull/7531?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services