You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/16 21:38:38 UTC
[GitHub] [superset] hughhhh commented on a change in pull request #19215: feat: add export_related flag
hughhhh commented on a change in pull request #19215:
URL: https://github.com/apache/superset/pull/19215#discussion_r828472655
##########
File path: superset/charts/commands/export.py
##########
@@ -43,7 +43,7 @@ class ExportChartsCommand(ExportModelsCommand):
not_found = ChartNotFoundError
@staticmethod
- def _export(model: Slice) -> Iterator[Tuple[str, str]]:
+ def _export(model: Slice, export_related: bool = True) -> Iterator[Tuple[str, str]]:
Review comment:
nit: i like `export_dependencies` instead of related
##########
File path: superset/charts/commands/export.py
##########
@@ -43,7 +43,7 @@ class ExportChartsCommand(ExportModelsCommand):
not_found = ChartNotFoundError
@staticmethod
- def _export(model: Slice) -> Iterator[Tuple[str, str]]:
+ def _export(model: Slice, export_related: bool = True) -> Iterator[Tuple[str, str]]:
Review comment:
nit: i like `export_dependencies` instead of related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org