You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/18 01:55:53 UTC

[GitHub] [arrow] jorgecarleitao commented on pull request #8213: ARROW-10034: [Rust] Fix Rust build on master

jorgecarleitao commented on pull request #8213:
URL: https://github.com/apache/arrow/pull/8213#issuecomment-694602195


   Thanks a lot for the quick response on solving this.
   
   One was related to a new trait in Arrow, `StringArrayOps`, that has `.value(i) -> &str`, and is needed when using `value` in strings, in the commit for `take`.
   
   The other one is related to the `Ops` in logical plans.
   
   Essentially, this is all related to multiple merges, with backward incompatible changes on them.
   
   @andygrove , is there anything we can do to help mitigating this during merge of multiple merges?
   
   One idea is to have a WARNING in the PR text that the merge is backward incompatible, so that the committer knows of potential conflicts with other merges.
   
   Another idea is to first perform the merges locally, one by one, and then push a branch with those changes to test them in integration, and then merge them at once.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org