You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/09/18 19:31:48 UTC
[kudu-CR] WIP: Import ArrayView type from WebRTC
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8095
to review the following change.
Change subject: WIP: Import ArrayView type from WebRTC
......................................................................
WIP: Import ArrayView type from WebRTC
See https://gerrit.cloudera.org/#/c/8009/ for motivation.
Imports the ArrayView type into util, along with its test from [1].
The test has been modified to add cases for faststring and Slice, and
remove the case for rtc::Buffer. ArrayView requires some template magic
from webrtc's type_traits.h which I copied to our type_traits.h.
WIP: Haven't looked at whether we need to add something to LICENSE.txt
yet. Mostly looking for validation that this is something we want to
do. Also not sure about legality of copying specific trait into
type_traits.h given the different headers.
[1]: https://chromium.googlesource.com/external/webrtc/+/a5f043f9cd201fff209e96415bebcb8445ba0176/api
Change-Id: If18020b78e25f147fd7f3c3f9127c9cd07637fe8
---
M src/kudu/gutil/CMakeLists.txt
A src/kudu/gutil/array_view-test.cc
A src/kudu/gutil/array_view.h
M src/kudu/gutil/type_traits.h
4 files changed, 662 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8095/1
--
To view, visit http://gerrit.cloudera.org:8080/8095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If18020b78e25f147fd7f3c3f9127c9cd07637fe8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP: Import ArrayView type from WebRTC
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: WIP: Import ArrayView type from WebRTC
......................................................................
Patch Set 1:
woops. duplicate.
--
To view, visit http://gerrit.cloudera.org:8080/8095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If18020b78e25f147fd7f3c3f9127c9cd07637fe8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] WIP: Import ArrayView type from WebRTC
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.
Change subject: WIP: Import ArrayView type from WebRTC
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/8095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If18020b78e25f147fd7f3c3f9127c9cd07637fe8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>