You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by andrea del bene <an...@gmail.com> on 2015/04/14 15:51:52 UTC
[VOTE] Release wicket-user-guide
This is a vote to release the new module wicket-user-guide.
This module is meant to integrate the user guide into the official GIT repository.
The module uses the Grails-Maven integration plugin in order to generate the guide
from Maven.
This will make guide maintenance much easier and we can have different version for different
branches (6.x, 7.x, etc..). Last but not least, this will make much easier to contribute
to the guide, as we move from Subverion to Git.
[ ] Yes, release it!
[ ] No, don't release it!
Feature branches branches:
-grails-maven-integration (for master branch)
-grails-maven-integration-6.x (for wicket-6.x branch)
Andrea.
Re: [VOTE] Release wicket-user-guide
Posted by andrea del bene <an...@gmail.com>.
On 14/04/2015 21:27, Martin Grigorov wrote:
> +1 to merge the branches
>
>
> Notes:
>
> *) Is there anything to be released?
> This is how I see it:
> - the new Maven module should be skipped by maven-deploy-plugin, just like
> wicket-js-tests [1], because there is no point to deploy empty .jar files
> - BuildBot activates profile 'guide' to produce the .html(s) and .pdf files
> and copies them to BuildBot's /tmp/ folder, as it currently does for the
> Javadoc, and links to them at http://wicket.apache.org, just like the
> Javadocs [2]
Well, great! I didn't know how it worked for javadoc. If we can use the
same infrastructure for the guide It would be perfect.
>
> *) If I run 'mvn clean install -Pguide' at the parent module the build
> fails with:
>
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 01:31 min
> [INFO] Finished at: 2015-04-14T22:16:27+02:00
> [INFO] Final Memory: 108M/3865M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.grails:grails-maven-plugin:2.2.4:exec
> (pdf) on project wicket-user-guide: Unable to start Grails:
> java.lang.reflect.InvocationTargetException: PermGen space -> [Help 1]
>
> If I build only wicket-user-guide module with the same Maven command then
> everything is OK.
> This is not big issue because 'guide' profile is disabled by default so it
> won't break my local builds. We can tell BuildBot to use more memory.
I've run the same command at the parent module but everything went fine.
This is my machine config:
mvn --version
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T18:37:52+01:00)
Maven home: /usr/share/maven3
Java version: 1.7.0_75, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-49-generic", arch: "amd64", family:
"unix"
>
> 1.
> https://github.com/apache/wicket/blob/8c83c5c50161b040fab0b748232a4fb5e7855e68/testing/wicket-js-tests/pom.xml#L44
> 2. http://ci.apache.org/projects/wicket/apidocs/6.x/,
> http://ci.apache.org/projects/wicket/apidocs/1.5.x/ and
> http://ci.apache.org/projects/wicket/apidocs/7.x/
>
> Martin Grigorov
> Freelancer, available for hire!
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Apr 14, 2015 at 6:38 PM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
>> +1
>>
>> kind regards
>>
>> Tobias
>>
>>> Am 14.04.2015 um 15:51 schrieb andrea del bene <an...@gmail.com>:
>>>
>>> This is a vote to release the new module wicket-user-guide.
>>>
>>> This module is meant to integrate the user guide into the official GIT
>> repository.
>>> The module uses the Grails-Maven integration plugin in order to generate
>> the guide
>>> from Maven.
>>> This will make guide maintenance much easier and we can have different
>> version for different
>>> branches (6.x, 7.x, etc..). Last but not least, this will make much
>> easier to contribute
>>> to the guide, as we move from Subverion to Git.
>>>
>>> [ ] Yes, release it!
>>> [ ] No, don't release it!
>>>
>>> Feature branches branches:
>>>
>>> -grails-maven-integration (for master branch)
>>> -grails-maven-integration-6.x (for wicket-6.x branch)
>>>
>>> Andrea.
>>>
Re: [VOTE] Release wicket-user-guide
Posted by Martin Grigorov <mg...@apache.org>.
+1 to merge the branches
Notes:
*) Is there anything to be released?
This is how I see it:
- the new Maven module should be skipped by maven-deploy-plugin, just like
wicket-js-tests [1], because there is no point to deploy empty .jar files
- BuildBot activates profile 'guide' to produce the .html(s) and .pdf files
and copies them to BuildBot's /tmp/ folder, as it currently does for the
Javadoc, and links to them at http://wicket.apache.org, just like the
Javadocs [2]
*) If I run 'mvn clean install -Pguide' at the parent module the build
fails with:
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:31 min
[INFO] Finished at: 2015-04-14T22:16:27+02:00
[INFO] Final Memory: 108M/3865M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.grails:grails-maven-plugin:2.2.4:exec
(pdf) on project wicket-user-guide: Unable to start Grails:
java.lang.reflect.InvocationTargetException: PermGen space -> [Help 1]
If I build only wicket-user-guide module with the same Maven command then
everything is OK.
This is not big issue because 'guide' profile is disabled by default so it
won't break my local builds. We can tell BuildBot to use more memory.
1.
https://github.com/apache/wicket/blob/8c83c5c50161b040fab0b748232a4fb5e7855e68/testing/wicket-js-tests/pom.xml#L44
2. http://ci.apache.org/projects/wicket/apidocs/6.x/,
http://ci.apache.org/projects/wicket/apidocs/1.5.x/ and
http://ci.apache.org/projects/wicket/apidocs/7.x/
Martin Grigorov
Freelancer, available for hire!
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Tue, Apr 14, 2015 at 6:38 PM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:
> +1
>
> kind regards
>
> Tobias
>
> > Am 14.04.2015 um 15:51 schrieb andrea del bene <an...@gmail.com>:
> >
> > This is a vote to release the new module wicket-user-guide.
> >
> > This module is meant to integrate the user guide into the official GIT
> repository.
> > The module uses the Grails-Maven integration plugin in order to generate
> the guide
> > from Maven.
> > This will make guide maintenance much easier and we can have different
> version for different
> > branches (6.x, 7.x, etc..). Last but not least, this will make much
> easier to contribute
> > to the guide, as we move from Subverion to Git.
> >
> > [ ] Yes, release it!
> > [ ] No, don't release it!
> >
> > Feature branches branches:
> >
> > -grails-maven-integration (for master branch)
> > -grails-maven-integration-6.x (for wicket-6.x branch)
> >
> > Andrea.
> >
>
Re: [VOTE] Release wicket-user-guide
Posted by Tobias Soloschenko <to...@googlemail.com>.
+1
kind regards
Tobias
> Am 14.04.2015 um 15:51 schrieb andrea del bene <an...@gmail.com>:
>
> This is a vote to release the new module wicket-user-guide.
>
> This module is meant to integrate the user guide into the official GIT repository.
> The module uses the Grails-Maven integration plugin in order to generate the guide
> from Maven.
> This will make guide maintenance much easier and we can have different version for different
> branches (6.x, 7.x, etc..). Last but not least, this will make much easier to contribute
> to the guide, as we move from Subverion to Git.
>
> [ ] Yes, release it!
> [ ] No, don't release it!
>
> Feature branches branches:
>
> -grails-maven-integration (for master branch)
> -grails-maven-integration-6.x (for wicket-6.x branch)
>
> Andrea.
>
Re: [VOTE] Release wicket-user-guide
Posted by andrea del bene <an...@gmail.com>.
I guess we can consider the vote as passed :).
Thank you guys, I will marge the two feature branches as soon as possible.
Andrea.
> This is a vote to release the new module wicket-user-guide.
>
> This module is meant to integrate the user guide into the official GIT
> repository.
> The module uses the Grails-Maven integration plugin in order to
> generate the guide
> from Maven.
> This will make guide maintenance much easier and we can have different
> version for different
> branches (6.x, 7.x, etc..). Last but not least, this will make much
> easier to contribute
> to the guide, as we move from Subverion to Git.
>
> [ ] Yes, release it!
> [ ] No, don't release it!
>
> Feature branches branches:
>
> -grails-maven-integration (for master branch)
> -grails-maven-integration-6.x (for wicket-6.x branch)
>
> Andrea.
>
Re: [VOTE] Release wicket-user-guide
Posted by andrea del bene <an...@gmail.com>.
+1
Andrea.
On 14/04/2015 15:51, andrea del bene wrote:
> This is a vote to release the new module wicket-user-guide.
>
> This module is meant to integrate the user guide into the official GIT
> repository.
> The module uses the Grails-Maven integration plugin in order to
> generate the guide
> from Maven.
> This will make guide maintenance much easier and we can have different
> version for different
> branches (6.x, 7.x, etc..). Last but not least, this will make much
> easier to contribute
> to the guide, as we move from Subverion to Git.
>
> [ ] Yes, release it!
> [ ] No, don't release it!
>
> Feature branches branches:
>
> -grails-maven-integration (for master branch)
> -grails-maven-integration-6.x (for wicket-6.x branch)
>
> Andrea.
>