You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (Created) (JIRA)" <ji...@apache.org> on 2012/01/04 22:13:39 UTC
[jira] [Created] (THRIFT-1484) Introduce phpunit test suite
Introduce phpunit test suite
-----------------------------
Key: THRIFT-1484
URL: https://issues.apache.org/jira/browse/THRIFT-1484
Project: Thrift
Issue Type: Improvement
Components: PHP - Compiler, PHP - Library, Test Suite
Environment: Ubuntu , Debian Squeeze
Reporter: Roger Meier
Assignee: Jake Farrell
The PHP implementation does not have a test suite, we need a lib/php/test/ folder and some basic unit tests.
phpunit seems to be the best solution for PHP testing, Debian Squeeze has 3.4.14 and we can request that on Buildserver, detect it via configure.ac and integrate it with *make check* build step.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1484) Introduce phpunit test suite
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179881#comment-13179881 ]
Jake Farrell commented on THRIFT-1484:
--------------------------------------
Some of the ci build servers all ready have phpunit installed, will get the checks added to configure shortly to automate running phpunit when available during make check
> Introduce phpunit test suite
> -----------------------------
>
> Key: THRIFT-1484
> URL: https://issues.apache.org/jira/browse/THRIFT-1484
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library, Test Suite
> Environment: Ubuntu , Debian Squeeze
> Reporter: Roger Meier
> Assignee: Jake Farrell
>
> The PHP implementation does not have a test suite, we need a lib/php/test/ folder and some basic unit tests.
> phpunit seems to be the best solution for PHP testing, Debian Squeeze has 3.4.14 and we can request that on Buildserver, detect it via configure.ac and integrate it with *make check* build step.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1484) Introduce phpunit test suite
Posted by "Andrew Grumet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190509#comment-13190509 ]
Andrew Grumet commented on THRIFT-1484:
---------------------------------------
Thanks, got it. So we can move on both fronts. On the test/<lang> side, it should be pretty straightforward to work the php code into test.sh, will give that a shot. On the lib/<lang>/test side, I'm going to start off by implementing some of the java unit tests in phpunit, and see how that goes.
> Introduce phpunit test suite
> -----------------------------
>
> Key: THRIFT-1484
> URL: https://issues.apache.org/jira/browse/THRIFT-1484
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library, Test Suite
> Environment: Ubuntu , Debian Squeeze
> Reporter: Roger Meier
> Assignee: Jake Farrell
>
> The PHP implementation does not have a test suite, we need a lib/php/test/ folder and some basic unit tests.
> phpunit seems to be the best solution for PHP testing, Debian Squeeze has 3.4.14 and we can request that on Buildserver, detect it via configure.ac and integrate it with *make check* build step.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1484) Introduce phpunit test suite
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1484.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.9
> Introduce phpunit test suite
> -----------------------------
>
> Key: THRIFT-1484
> URL: https://issues.apache.org/jira/browse/THRIFT-1484
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library, Test Suite
> Environment: Ubuntu , Debian Squeeze
> Reporter: Roger Meier
> Assignee: Jake Farrell
> Fix For: 0.9
>
>
> The PHP implementation does not have a test suite, we need a lib/php/test/ folder and some basic unit tests.
> phpunit seems to be the best solution for PHP testing, Debian Squeeze has 3.4.14 and we can request that on Buildserver, detect it via configure.ac and integrate it with *make check* build step.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1484) Introduce phpunit test suite
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189850#comment-13189850 ]
Roger Meier commented on THRIFT-1484:
-------------------------------------
* test/<lang> is used for TestClient and TestServer used also for crosslanguage tests (test/test.sh)
* lib/<lang>/test is unit test for the language
Yes, patches to enhance the test suite and cross language tests are very welcome!
> Introduce phpunit test suite
> -----------------------------
>
> Key: THRIFT-1484
> URL: https://issues.apache.org/jira/browse/THRIFT-1484
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library, Test Suite
> Environment: Ubuntu , Debian Squeeze
> Reporter: Roger Meier
> Assignee: Jake Farrell
>
> The PHP implementation does not have a test suite, we need a lib/php/test/ folder and some basic unit tests.
> phpunit seems to be the best solution for PHP testing, Debian Squeeze has 3.4.14 and we can request that on Buildserver, detect it via configure.ac and integrate it with *make check* build step.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1484) Introduce phpunit test suite
Posted by "Andrew Grumet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189684#comment-13189684 ]
Andrew Grumet commented on THRIFT-1484:
---------------------------------------
Found and patched some very basic test code in test/php. Not sure what is the difference between test/<lang> and lib/<lang>/test. Happy to help here.
> Introduce phpunit test suite
> -----------------------------
>
> Key: THRIFT-1484
> URL: https://issues.apache.org/jira/browse/THRIFT-1484
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler, PHP - Library, Test Suite
> Environment: Ubuntu , Debian Squeeze
> Reporter: Roger Meier
> Assignee: Jake Farrell
>
> The PHP implementation does not have a test suite, we need a lib/php/test/ folder and some basic unit tests.
> phpunit seems to be the best solution for PHP testing, Debian Squeeze has 3.4.14 and we can request that on Buildserver, detect it via configure.ac and integrate it with *make check* build step.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira