You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/03/21 21:23:56 UTC

[GitHub] [arrow-rs] Weijun-H opened a new pull request, #3897: feat: add sort_dictionary

Weijun-H opened a new pull request, #3897:
URL: https://github.com/apache/arrow-rs/pull/3897

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part #1218
   
   # Rationale for this change
    Add `sort_dictionary` and `pack_dictionary` options.
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   Sort element if `sort_dictionary` is true, not implement `pack_dictionary` because I am not sure how to depulicate the array.
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3897: feat: add sort_dictionary

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3897:
URL: https://github.com/apache/arrow-rs/pull/3897#issuecomment-1478630321

   Apologies I must have missed this whilst pruning the backlog, I'll endeavour to write up a proper ticket for how to support this, if this is even something we want to support - the current story for sorted dictionaries is extremely incomplete


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3897: feat: add sort_dictionary

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3897:
URL: https://github.com/apache/arrow-rs/pull/3897#discussion_r1144018529


##########
arrow-cast/Cargo.toml:
##########
@@ -49,6 +49,7 @@ arrow-buffer = { version = "35.0.0", path = "../arrow-buffer" }
 arrow-data = { version = "35.0.0", path = "../arrow-data" }
 arrow-schema = { version = "35.0.0", path = "../arrow-schema" }
 arrow-select = { version = "35.0.0", path = "../arrow-select" }
+arrow-ord = { version = "35.0.0", path = "../arrow-ord" }

Review Comment:
   I would really strongly like to avoid this, this is the single heaviest crate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3897: feat: add sort_dictionary

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3897:
URL: https://github.com/apache/arrow-rs/pull/3897#issuecomment-1478625277

   Sorry I didn't realise you were working on this, I'm not sure this is a good idea anymore...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed pull request #3897: feat: add sort_dictionary

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #3897: feat: add sort_dictionary
URL: https://github.com/apache/arrow-rs/pull/3897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org