You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2024/03/28 20:36:52 UTC
[PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Taragolis opened a new pull request, #38594:
URL: https://github.com/apache/airflow/pull/38594
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
- [import mode](https://docs.pytest.org/en/latest/explanation/pythonpath.html#import-modes)
- [Choosing a test layout / import rules](https://docs.pytest.org/en/latest/explanation/goodpractices.html#choosing-an-import-mode)
Just an experiment whether or not airflow tests could use `importlib` mode instead of `prepend`
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis closed pull request #38594: [Experiment] Use `importlib` import mode for `pytest`
URL: https://github.com/apache/airflow/pull/38594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #38594:
URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026275654
> interesting . I had no idea pytest is doing that.
I've found myself it about week ago when try to find how to solve one issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #38594:
URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026281241
🤔 🤔 🤔
```console
# Provide existent file path,
# so loaded YAML file content should be used to call deserialize_model_dict(), rather than None.
path = sys.path[0] + "/tests/providers/cncf/kubernetes/pod.yaml"
> with open(path) as stream:
E FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/bin/tests/providers/cncf/kubernetes/pod.yaml'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38594:
URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026283948
> path = sys.path[0] + "/tests/providers/cncf/kubernetes/pod.yaml"
Yeah. Someone took advantage of assuming sys.path will be modified :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38594:
URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026264100
interesting . I had no idea pytest is doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38594:
URL: https://github.com/apache/airflow/pull/38594#issuecomment-2119466398
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #38594: [Experiment] Use `importlib` import mode for `pytest`
URL: https://github.com/apache/airflow/pull/38594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #38594:
URL: https://github.com/apache/airflow/pull/38594#discussion_r1544572827
##########
pyproject.toml:
##########
@@ -445,7 +445,15 @@ fixture-parentheses = false
# * Disable `flaky` plugin for pytest. This plugin conflicts with `rerunfailures` because provide same marker.
# * Disable `nose` builtin plugin for pytest. This feature deprecated in 7.2 and will be removed in pytest>=8
# * And we focus on use native pytest capabilities rather than adopt another frameworks.
-addopts = "-rasl --verbosity=2 -p no:flaky -p no:nose --asyncio-mode=strict"
+addopts = [
+ "-rasl",
+ "--verbosity=2",
+ "-p", "no:flaky",
+ "-p", "no:nose",
+ "-p", "no:legacypath",
Review Comment:
Well, I thought it doesn't add by a mistake, however seems like our tests use legacy LocalPath in some places
```console
@pytest.fixture(autouse=True)
def refuse_to_run_test_from_wrongly_named_files(request):
> dirname: str = request.node.fspath.dirname
E AttributeError: 'Function' object has no attribute 'fspath'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org