You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/03/26 00:37:50 UTC
[jira] Created: (HADOOP-5574) Separate replication setting out from
FSNamesystem
Separate replication setting out from FSNamesystem
--------------------------------------------------
Key: HADOOP-5574
URL: https://issues.apache.org/jira/browse/HADOOP-5574
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
Priority: Minor
Replication related setting, included default/min/max replication, etc., deserves a separated class to make the codes in FSNamesystem cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5574) Separate replication setting out from
FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5574:
-------------------------------------------
Attachment: 5574_20090325.patch
5574_20090325.patch: introduced a new class ReplicationSetting
> Separate replication setting out from FSNamesystem
> --------------------------------------------------
>
> Key: HADOOP-5574
> URL: https://issues.apache.org/jira/browse/HADOOP-5574
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 5574_20090325.patch
>
>
> Replication related setting, included default/min/max replication, etc., deserves a separated class to make the codes in FSNamesystem cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5574) Separate replication setting out
from FSNamesystem
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695828#action_12695828 ]
dhruba borthakur commented on HADOOP-5574:
------------------------------------------
This definitely helps in readability and maintain-ablity of FSNameSystem.java
> Separate replication setting out from FSNamesystem
> --------------------------------------------------
>
> Key: HADOOP-5574
> URL: https://issues.apache.org/jira/browse/HADOOP-5574
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 5574_20090325.patch
>
>
> Replication related setting, included default/min/max replication, etc., deserves a separated class to make the codes in FSNamesystem cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5574) Separate replication setting out
from FSNamesystem
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689559#action_12689559 ]
Suresh Srinivas commented on HADOOP-5574:
-----------------------------------------
# {{TestReplicationSetting}} - is there a reason to print GOOD IOException? Can it be quietly ignored?
# {{ReplicationSetting}} constructor could use the member vairables instead of defining new variables. Also by making method {{isValid}} final, you could reuse it to check if the {{defaultvalue}} is in the min-max range.
# {{ReplicationSetting.adjust()} the method comment is not very clear as to what adjusted means
> Separate replication setting out from FSNamesystem
> --------------------------------------------------
>
> Key: HADOOP-5574
> URL: https://issues.apache.org/jira/browse/HADOOP-5574
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 5574_20090325.patch
>
>
> Replication related setting, included default/min/max replication, etc., deserves a separated class to make the codes in FSNamesystem cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5574) Separate replication setting out
from FSNamesystem
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-5574.
--------------------------------------------
Resolution: Duplicate
This will be fixed in HADOOP-5015.
> Separate replication setting out from FSNamesystem
> --------------------------------------------------
>
> Key: HADOOP-5574
> URL: https://issues.apache.org/jira/browse/HADOOP-5574
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 5574_20090325.patch
>
>
> Replication related setting, included default/min/max replication, etc., deserves a separated class to make the codes in FSNamesystem cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.