You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2025/07/06 23:08:47 UTC
[native-toolchain-CR] Update container build Python scripts to Python3
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23133
Change subject: Update container build Python scripts to Python3
......................................................................
Update container build Python scripts to Python3
This patch prepares the toolchain container build process to run on
recent operating systems, where Python2 is not readily available. It
replaces Python2 idioms with constructs or modules available across both
Python major versions.
Details:
Old code used distutils.sysconfig for locating Python.h during dependency
installation checking. This module is not supported for recent versions
of Python3, so switch to the sysconfig module, which is supported
everywhere.
The filter/iterator logic in in-docker.py used to take len() of an
iterator directly, which cannot be done in Python 3. Change the filter
to a list comprehension, so the result list can be checked the same way.
Change-Id: Ief756d69d6acff60a3476cc849a95559ec5ac715
---
M docker/all/assert-dependencies-present.py
M in-docker.py
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/33/23133/1
--
To view, visit http://gerrit.cloudera.org:8080/23133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief756d69d6acff60a3476cc849a95559ec5ac715
Gerrit-Change-Number: 23133
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] Update container build Python scripts to Python3
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has abandoned this change. ( http://gerrit.cloudera.org:8080/23133 )
Change subject: Update container build Python scripts to Python3
......................................................................
Abandoned
Squashed into https://gerrit.cloudera.org/c/23128/
--
To view, visit http://gerrit.cloudera.org:8080/23133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ief756d69d6acff60a3476cc849a95559ec5ac715
Gerrit-Change-Number: 23133
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] Update container build Python scripts to Python3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23133 )
Change subject: Update container build Python scripts to Python3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23133/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23133/1//COMMIT_MSG@21
PS1, Line 21: The filter/iterator logic in in-docker.py used to take len() of an
The issue here was that filter became lazy, so you needed to wrap it in `list(filter(...))` to materialize the results. List comprehensions are fine too.
--
To view, visit http://gerrit.cloudera.org:8080/23133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief756d69d6acff60a3476cc849a95559ec5ac715
Gerrit-Change-Number: 23133
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 18:05:42 +0000
Gerrit-HasComments: Yes