You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/04 14:07:41 UTC
[GitHub] [lucene-solr] rmuir commented on issue #1236: Add back assertions
removed by LUCENE-9187.
rmuir commented on issue #1236: Add back assertions removed by LUCENE-9187.
URL: https://github.com/apache/lucene-solr/pull/1236#issuecomment-581925613
I think the randomize() stuff in {{src/java}} is confusing to follow and does not belong there.
maybe we should defer/split that and just get the assertion working again? It seems enough to add back the assertReset, but only call it from AssertingHashTable like you did here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org