You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/07/01 07:59:37 UTC
Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
Repository: cloudstack-git
Description
-------
Incorporated some feed back items.
Diffs
-----
client/pom.xml 29fef4f
scripts/installer/windows/ExitDialog.wxs PRE-CREATION
scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
scripts/installer/windows/acs.wxs bf09afc
scripts/installer/windows/dependencies.wxs 987c561
scripts/installer/windows/en-us.wxl 2f34575
scripts/installer/windows/optionstheme_en-us.wxl c822929
scripts/installer/windows/readme.txt PRE-CREATION
Diff: https://reviews.apache.org/r/23192/diff/
Testing
-------
Tested on Windows 2012 Server
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
> > I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch.
>
> Koushik Das wrote:
> Hugo, I committed this patch (on master ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this comment from you. If there is going to be a license issue then please feel free to revert.
Hugo,
We are not packaging the connector with MSI, indeed we are downloading it from the Internet during installation similar to Linux environments.
- Damodar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47289
-----------------------------------------------------------
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
RE: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Damoder Reddy <Da...@citrix.com>.
Hugo,
As Rajani mentioned we are not packaging the sources with MSI installer, we are telling to installer from where to download the dependencies.
Anyhow my question is, the MSI build is already part of separate build profile ("buildw") which is not build with default profile. So still we need to move it to under noredist profile?
Damoder/
-----Original Message-----
From: Rajani Karuturi [mailto:Rajani.Karuturi@citrix.com]
Sent: Wednesday, 9 July 2014 10:45 AM
To: dev@cloudstack.apache.org
Cc: David Nalley; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a [spec] file. only difference being, it also mentions the download url as windows doesn’t have a package repository and doesn’t know where to download from.
It will not be part of the installer. The msi only tells where to download the mysql connector jar from. It doesn’t include the jar itself.
When the user is installing cloudstack using the msi, the jar will be downloaded from the location mentioned.
[spec] https://reviews.apache.org/r/23192/diff/#5
~Rajani
On 08-Jul-2014, at 7:25 pm, Hugo Trippaers <hu...@trippaers.nl>> wrote:
Rajani,
That is why we renamed nonoss to noredist. It has to do with the policy of the Apache Software Foundation regarding compatible licenses [1]. The problem in this case is subtle, but there is a difference. The main point in the discussion is so-called system dependencies. We know we need java, mysql and the mysql-connector-java to be installed before we can install our packages. This is what the dependency on mysql-connector-java in the spec file indicates. Creating a package containing those source is actually including the items we consider is going just a bit further and to a point where we concluded that it is not inline with the apache policies. So it is perfectly alright to include a popup in the installer that tells the users that he needs to install mysql, java etc, but we can’t have an installed in the source that will do that for the user as part of the installer.
What David proposes is a the middle ground where we can keep the installer in the configured like this in the pom, but it can’t be in that standard build, but only in the build that know we can’t redistribute (the noredist build). We will never make the artifacts resulting from that build available, but other entities can make them available. By specifying noredist on the build command we can be reasonably sure that the builder has been informed that distribution restrictions might apply on whatever it is he is doing.
Cheers,
Hugo
[1] http://www.apache.org/legal/resolved.html#category-x
On 8 jul. 2014, at 12:57, Rajani Karuturi <Ra...@citrix.com>> wrote:
I believe this has nothing to do with nonoss. If I understand it right, nonoss modules are required for cloudstack to work with certain 3rd party stuff.
This one is just a helper to create a windows installer. It chose to use a mvn command to create the installer instead of shell/bat script. It should work with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm and which already has mysql-connector-java already listed as required package.
I think the right way would be to create independent git repos for deb/rpm/windows installers/packages.
In its current state, I don’t see it any different from other helper installer scripts we already have.
[1] https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD
~Rajani
On 08-Jul-2014, at 9:56 am, Damoder Reddy <Da...@citrix.com>> wrote:
Ok,
To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
Thanks
Damoder/
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org<ma...@cloudstack.apache.org>
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org>> wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one of łleast surprise˛: As a user or developer who does not RTFM, following the default commands/tools/etc, you should end up with a more-or-less apache-licensed build result (*) that you can redistribute the result under.
+1
But apache policy is that it is acceptable to provide scripts/build tools/assistance to help those same users/developers do things that they want to do. As long as they understand the legal situation they end up in.
I would recommend adding a "nonoss" maven profile that the developer/user has to explicitly select in order to do those downloads. As long as that option is described clearly, thatąs then ok. See
http://svn.apache.org/repos/asf/apr/apr/trunk/README
for an example of how to point out the license situation.
We already have the nonoss profile, so this is a pretty good fix for the windows build issues noted above IMO.
Damoder/Koushik - please make this change.
Something similar is true by the way (IMHO, but as a project cloudstack can definitely decide differently), for a possible MSI script. Making an MSI script that prompts the user whether to download mysql at the point of install, **clearly pointing out the license situation** if they choose to do so, seems reasonable, and I personally would not object to shipping _that_ kind of script as part of an apache source release.
+1 - that's a reasonable approach as well. Damoder / Koushik - what do
you think about this approach?
I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
Finally, the _spirit_ behind the apache policies is that there should
be an option to use cloudstack with a license-compatible database
(say, postgres), even if most users will use mysql (just like most
people that use dbm with httpd will use berkely dbm, but you _can_
use something else). Itąs perhaps unfortunate that this isnąt
supported, but thatąs not apache policy, and given the license
situation of other system dependencies, I can imagine no-one here wants to make it a priority.
Yeah, that would be nice... but somebody would have to decide that
they want to do that.
cheers,
Leo
PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
is about choice/policy, and the policy is supposed to be based on
common sense much more than license stuff tends to be :)
Agreed - this is about policy not legality.
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Rajani Karuturi <Ra...@citrix.com>.
Hi Hugo,
Does this make sense? Do you still think it should be part of noredist profile?
~Rajani
On 09-Jul-2014, at 10:44 am, Rajani Karuturi <Ra...@citrix.com>> wrote:
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a [spec] file. only difference being, it also mentions the download url as windows doesn’t have a package repository and doesn’t know where to download from.
It will not be part of the installer. The msi only tells where to download the mysql connector jar from. It doesn’t include the jar itself.
When the user is installing cloudstack using the msi, the jar will be downloaded from the location mentioned.
[spec] https://reviews.apache.org/r/23192/diff/#5
~Rajani
On 08-Jul-2014, at 7:25 pm, Hugo Trippaers <hu...@trippaers.nl>> wrote:
Rajani,
That is why we renamed nonoss to noredist. It has to do with the policy of the Apache Software Foundation regarding compatible licenses [1]. The problem in this case is subtle, but there is a difference. The main point in the discussion is so-called system dependencies. We know we need java, mysql and the mysql-connector-java to be installed before we can install our packages. This is what the dependency on mysql-connector-java in the spec file indicates. Creating a package containing those source is actually including the items we consider is going just a bit further and to a point where we concluded that it is not inline with the apache policies. So it is perfectly alright to include a popup in the installer that tells the users that he needs to install mysql, java etc, but we can’t have an installed in the source that will do that for the user as part of the installer.
What David proposes is a the middle ground where we can keep the installer in the configured like this in the pom, but it can’t be in that standard build, but only in the build that know we can’t redistribute (the noredist build). We will never make the artifacts resulting from that build available, but other entities can make them available. By specifying noredist on the build command we can be reasonably sure that the builder has been informed that distribution restrictions might apply on whatever it is he is doing.
Cheers,
Hugo
[1] http://www.apache.org/legal/resolved.html#category-x
On 8 jul. 2014, at 12:57, Rajani Karuturi <Ra...@citrix.com>> wrote:
I believe this has nothing to do with nonoss. If I understand it right, nonoss modules are required for cloudstack to work with certain 3rd party stuff.
This one is just a helper to create a windows installer. It chose to use a mvn command to create the installer instead of shell/bat script. It should work with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm and which already has mysql-connector-java already listed as required package.
I think the right way would be to create independent git repos for deb/rpm/windows installers/packages.
In its current state, I don’t see it any different from other helper installer scripts we already have.
[1] https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD
~Rajani
On 08-Jul-2014, at 9:56 am, Damoder Reddy <Da...@citrix.com>> wrote:
Ok,
To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
Thanks
Damoder/
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org<ma...@cloudstack.apache.org>
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org>> wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one
of łleast surprise˛: As a user or developer who does not RTFM,
following the default commands/tools/etc, you should end up with a
more-or-less apache-licensed build result (*) that you can
redistribute the result under.
+1
But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that
they want to do. As long as they understand the legal situation they end up in.
I would recommend adding a "nonoss" maven profile that the
developer/user has to explicitly select in order to do those
downloads. As long as that option is described clearly, thatąs then
ok. See
http://svn.apache.org/repos/asf/apr/apr/trunk/README
for an example of how to point out the license situation.
We already have the nonoss profile, so this is a pretty good fix for
the windows build issues noted above IMO.
Damoder/Koushik - please make this change.
Something similar is true by the way (IMHO, but as a project
cloudstack can definitely decide differently), for a possible MSI
script. Making an MSI script that prompts the user whether to
download mysql at the point of install, **clearly pointing out the
license situation** if they choose to do so, seems reasonable, and I
personally would not object to shipping _that_ kind of script as part of an apache source release.
+1 - that's a reasonable approach as well. Damoder / Koushik - what
+do
you think about this approach?
I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
Finally, the _spirit_ behind the apache policies is that there should
be an option to use cloudstack with a license-compatible database
(say, postgres), even if most users will use mysql (just like most
people that use dbm with httpd will use berkely dbm, but you _can_
use something else). Itąs perhaps unfortunate that this isnąt
supported, but thatąs not apache policy, and given the license
situation of other system dependencies, I can imagine no-one here wants to make it a priority.
Yeah, that would be nice... but somebody would have to decide that
they want to do that.
cheers,
Leo
PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
is about choice/policy, and the policy is supposed to be based on
common sense much more than license stuff tends to be :)
Agreed - this is about policy not legality.
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Rajani Karuturi <Ra...@citrix.com>.
Hi Hugo,
Does this make sense? Do you still think it should be part of noredist profile?
~Rajani
On 09-Jul-2014, at 10:44 am, Rajani Karuturi <Ra...@citrix.com>> wrote:
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a [spec] file. only difference being, it also mentions the download url as windows doesn’t have a package repository and doesn’t know where to download from.
It will not be part of the installer. The msi only tells where to download the mysql connector jar from. It doesn’t include the jar itself.
When the user is installing cloudstack using the msi, the jar will be downloaded from the location mentioned.
[spec] https://reviews.apache.org/r/23192/diff/#5
~Rajani
On 08-Jul-2014, at 7:25 pm, Hugo Trippaers <hu...@trippaers.nl>> wrote:
Rajani,
That is why we renamed nonoss to noredist. It has to do with the policy of the Apache Software Foundation regarding compatible licenses [1]. The problem in this case is subtle, but there is a difference. The main point in the discussion is so-called system dependencies. We know we need java, mysql and the mysql-connector-java to be installed before we can install our packages. This is what the dependency on mysql-connector-java in the spec file indicates. Creating a package containing those source is actually including the items we consider is going just a bit further and to a point where we concluded that it is not inline with the apache policies. So it is perfectly alright to include a popup in the installer that tells the users that he needs to install mysql, java etc, but we can’t have an installed in the source that will do that for the user as part of the installer.
What David proposes is a the middle ground where we can keep the installer in the configured like this in the pom, but it can’t be in that standard build, but only in the build that know we can’t redistribute (the noredist build). We will never make the artifacts resulting from that build available, but other entities can make them available. By specifying noredist on the build command we can be reasonably sure that the builder has been informed that distribution restrictions might apply on whatever it is he is doing.
Cheers,
Hugo
[1] http://www.apache.org/legal/resolved.html#category-x
On 8 jul. 2014, at 12:57, Rajani Karuturi <Ra...@citrix.com>> wrote:
I believe this has nothing to do with nonoss. If I understand it right, nonoss modules are required for cloudstack to work with certain 3rd party stuff.
This one is just a helper to create a windows installer. It chose to use a mvn command to create the installer instead of shell/bat script. It should work with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm and which already has mysql-connector-java already listed as required package.
I think the right way would be to create independent git repos for deb/rpm/windows installers/packages.
In its current state, I don’t see it any different from other helper installer scripts we already have.
[1] https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD
~Rajani
On 08-Jul-2014, at 9:56 am, Damoder Reddy <Da...@citrix.com>> wrote:
Ok,
To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
Thanks
Damoder/
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org<ma...@cloudstack.apache.org>
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org>> wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one
of łleast surprise˛: As a user or developer who does not RTFM,
following the default commands/tools/etc, you should end up with a
more-or-less apache-licensed build result (*) that you can
redistribute the result under.
+1
But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that
they want to do. As long as they understand the legal situation they end up in.
I would recommend adding a "nonoss" maven profile that the
developer/user has to explicitly select in order to do those
downloads. As long as that option is described clearly, thatąs then
ok. See
http://svn.apache.org/repos/asf/apr/apr/trunk/README
for an example of how to point out the license situation.
We already have the nonoss profile, so this is a pretty good fix for
the windows build issues noted above IMO.
Damoder/Koushik - please make this change.
Something similar is true by the way (IMHO, but as a project
cloudstack can definitely decide differently), for a possible MSI
script. Making an MSI script that prompts the user whether to
download mysql at the point of install, **clearly pointing out the
license situation** if they choose to do so, seems reasonable, and I
personally would not object to shipping _that_ kind of script as part of an apache source release.
+1 - that's a reasonable approach as well. Damoder / Koushik - what
+do
you think about this approach?
I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
Finally, the _spirit_ behind the apache policies is that there should
be an option to use cloudstack with a license-compatible database
(say, postgres), even if most users will use mysql (just like most
people that use dbm with httpd will use berkely dbm, but you _can_
use something else). Itąs perhaps unfortunate that this isnąt
supported, but thatąs not apache policy, and given the license
situation of other system dependencies, I can imagine no-one here wants to make it a priority.
Yeah, that would be nice... but somebody would have to decide that
they want to do that.
cheers,
Leo
PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
is about choice/policy, and the policy is supposed to be based on
common sense much more than license stuff tends to be :)
Agreed - this is about policy not legality.
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Rajani Karuturi <Ra...@citrix.com>.
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a [spec] file. only difference being, it also mentions the download url as windows doesn’t have a package repository and doesn’t know where to download from.
It will not be part of the installer. The msi only tells where to download the mysql connector jar from. It doesn’t include the jar itself.
When the user is installing cloudstack using the msi, the jar will be downloaded from the location mentioned.
[spec] https://reviews.apache.org/r/23192/diff/#5
~Rajani
On 08-Jul-2014, at 7:25 pm, Hugo Trippaers <hu...@trippaers.nl>> wrote:
Rajani,
That is why we renamed nonoss to noredist. It has to do with the policy of the Apache Software Foundation regarding compatible licenses [1]. The problem in this case is subtle, but there is a difference. The main point in the discussion is so-called system dependencies. We know we need java, mysql and the mysql-connector-java to be installed before we can install our packages. This is what the dependency on mysql-connector-java in the spec file indicates. Creating a package containing those source is actually including the items we consider is going just a bit further and to a point where we concluded that it is not inline with the apache policies. So it is perfectly alright to include a popup in the installer that tells the users that he needs to install mysql, java etc, but we can’t have an installed in the source that will do that for the user as part of the installer.
What David proposes is a the middle ground where we can keep the installer in the configured like this in the pom, but it can’t be in that standard build, but only in the build that know we can’t redistribute (the noredist build). We will never make the artifacts resulting from that build available, but other entities can make them available. By specifying noredist on the build command we can be reasonably sure that the builder has been informed that distribution restrictions might apply on whatever it is he is doing.
Cheers,
Hugo
[1] http://www.apache.org/legal/resolved.html#category-x
On 8 jul. 2014, at 12:57, Rajani Karuturi <Ra...@citrix.com>> wrote:
I believe this has nothing to do with nonoss. If I understand it right, nonoss modules are required for cloudstack to work with certain 3rd party stuff.
This one is just a helper to create a windows installer. It chose to use a mvn command to create the installer instead of shell/bat script. It should work with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm and which already has mysql-connector-java already listed as required package.
I think the right way would be to create independent git repos for deb/rpm/windows installers/packages.
In its current state, I don’t see it any different from other helper installer scripts we already have.
[1] https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD
~Rajani
On 08-Jul-2014, at 9:56 am, Damoder Reddy <Da...@citrix.com>> wrote:
Ok,
To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
Thanks
Damoder/
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org<ma...@cloudstack.apache.org>
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org>> wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one
of łleast surprise˛: As a user or developer who does not RTFM,
following the default commands/tools/etc, you should end up with a
more-or-less apache-licensed build result (*) that you can
redistribute the result under.
+1
But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that
they want to do. As long as they understand the legal situation they end up in.
I would recommend adding a "nonoss" maven profile that the
developer/user has to explicitly select in order to do those
downloads. As long as that option is described clearly, thatąs then
ok. See
http://svn.apache.org/repos/asf/apr/apr/trunk/README
for an example of how to point out the license situation.
We already have the nonoss profile, so this is a pretty good fix for
the windows build issues noted above IMO.
Damoder/Koushik - please make this change.
Something similar is true by the way (IMHO, but as a project
cloudstack can definitely decide differently), for a possible MSI
script. Making an MSI script that prompts the user whether to
download mysql at the point of install, **clearly pointing out the
license situation** if they choose to do so, seems reasonable, and I
personally would not object to shipping _that_ kind of script as part of an apache source release.
+1 - that's a reasonable approach as well. Damoder / Koushik - what
+do
you think about this approach?
I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
Finally, the _spirit_ behind the apache policies is that there should
be an option to use cloudstack with a license-compatible database
(say, postgres), even if most users will use mysql (just like most
people that use dbm with httpd will use berkely dbm, but you _can_
use something else). Itąs perhaps unfortunate that this isnąt
supported, but thatąs not apache policy, and given the license
situation of other system dependencies, I can imagine no-one here wants to make it a priority.
Yeah, that would be nice... but somebody would have to decide that
they want to do that.
cheers,
Leo
PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
is about choice/policy, and the policy is supposed to be based on
common sense much more than license stuff tends to be :)
Agreed - this is about policy not legality.
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
Posted by Hugo Trippaers <hu...@trippaers.nl>.
Rajani,
That is why we renamed nonoss to noredist. It has to do with the policy of the Apache Software Foundation regarding compatible licenses [1]. The problem in this case is subtle, but there is a difference. The main point in the discussion is so-called system dependencies. We know we need java, mysql and the mysql-connector-java to be installed before we can install our packages. This is what the dependency on mysql-connector-java in the spec file indicates. Creating a package containing those source is actually including the items we consider is going just a bit further and to a point where we concluded that it is not inline with the apache policies. So it is perfectly alright to include a popup in the installer that tells the users that he needs to install mysql, java etc, but we can’t have an installed in the source that will do that for the user as part of the installer.
What David proposes is a the middle ground where we can keep the installer in the configured like this in the pom, but it can’t be in that standard build, but only in the build that know we can’t redistribute (the noredist build). We will never make the artifacts resulting from that build available, but other entities can make them available. By specifying noredist on the build command we can be reasonably sure that the builder has been informed that distribution restrictions might apply on whatever it is he is doing.
Cheers,
Hugo
[1] http://www.apache.org/legal/resolved.html#category-x
On 8 jul. 2014, at 12:57, Rajani Karuturi <Ra...@citrix.com> wrote:
> I believe this has nothing to do with nonoss. If I understand it right, nonoss modules are required for cloudstack to work with certain 3rd party stuff.
>
> This one is just a helper to create a windows installer. It chose to use a mvn command to create the installer instead of shell/bat script. It should work with either nonoss or oss modules.
> This is very similar to cloud.spec[1] we have which is used to create the rpm and which already has mysql-connector-java already listed as required package.
>
> I think the right way would be to create independent git repos for deb/rpm/windows installers/packages.
>
> In its current state, I don’t see it any different from other helper installer scripts we already have.
>
> [1] https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD
>
> ~Rajani
>
>
>
> On 08-Jul-2014, at 9:56 am, Damoder Reddy <Da...@citrix.com>> wrote:
>
> Ok,
>
> To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
>
> Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
>
> Thanks
> Damoder/
>
> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Thursday, 3 July 2014 9:58 PM
> To: dev@cloudstack.apache.org<ma...@cloudstack.apache.org>
> Cc: Damoder Reddy; Koushik Das
> Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
>
> On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org>> wrote:
> On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
> It looks like that maven pom on windows _by default_ downloads and
> installs a variety of non-apache-license (and/or non-mit/bsd/variant
> license) software. That shouldnąt really happen. The principle is one
> of łleast surprise˛: As a user or developer who does not RTFM,
> following the default commands/tools/etc, you should end up with a
> more-or-less apache-licensed build result (*) that you can
> redistribute the result under.
>
> +1
>
>
> But apache policy is that it is acceptable to provide scripts/build
> tools/assistance to help those same users/developers do things that
> they want to do. As long as they understand the legal situation they end up in.
>
> I would recommend adding a "nonoss" maven profile that the
> developer/user has to explicitly select in order to do those
> downloads. As long as that option is described clearly, thatąs then
> ok. See
>
> http://svn.apache.org/repos/asf/apr/apr/trunk/README
>
> for an example of how to point out the license situation.
>
> We already have the nonoss profile, so this is a pretty good fix for
> the windows build issues noted above IMO.
>
> Damoder/Koushik - please make this change.
>
>
> Something similar is true by the way (IMHO, but as a project
> cloudstack can definitely decide differently), for a possible MSI
> script. Making an MSI script that prompts the user whether to
> download mysql at the point of install, **clearly pointing out the
> license situation** if they choose to do so, seems reasonable, and I
> personally would not object to shipping _that_ kind of script as part of an apache source release.
>
>
> +1 - that's a reasonable approach as well. Damoder / Koushik - what
> +do
> you think about this approach?
>
>
> I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
>
>
>
> Finally, the _spirit_ behind the apache policies is that there should
> be an option to use cloudstack with a license-compatible database
> (say, postgres), even if most users will use mysql (just like most
> people that use dbm with httpd will use berkely dbm, but you _can_
> use something else). Itąs perhaps unfortunate that this isnąt
> supported, but thatąs not apache policy, and given the license
> situation of other system dependencies, I can imagine no-one here wants to make it a priority.
>
> Yeah, that would be nice... but somebody would have to decide that
> they want to do that.
>
>
>
> cheers,
>
>
> Leo
>
> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
> is about choice/policy, and the policy is supposed to be based on
> common sense much more than license stuff tends to be :)
>
> Agreed - this is about policy not legality.
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Rajani Karuturi <Ra...@citrix.com>.
I believe this has nothing to do with nonoss. If I understand it right, nonoss modules are required for cloudstack to work with certain 3rd party stuff.
This one is just a helper to create a windows installer. It chose to use a mvn command to create the installer instead of shell/bat script. It should work with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm and which already has mysql-connector-java already listed as required package.
I think the right way would be to create independent git repos for deb/rpm/windows installers/packages.
In its current state, I don’t see it any different from other helper installer scripts we already have.
[1] https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD
~Rajani
On 08-Jul-2014, at 9:56 am, Damoder Reddy <Da...@citrix.com>> wrote:
Ok,
To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
Thanks
Damoder/
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org<ma...@cloudstack.apache.org>
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org>> wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one
of łleast surprise˛: As a user or developer who does not RTFM,
following the default commands/tools/etc, you should end up with a
more-or-less apache-licensed build result (*) that you can
redistribute the result under.
+1
But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that
they want to do. As long as they understand the legal situation they end up in.
I would recommend adding a "nonoss" maven profile that the
developer/user has to explicitly select in order to do those
downloads. As long as that option is described clearly, thatąs then
ok. See
http://svn.apache.org/repos/asf/apr/apr/trunk/README
for an example of how to point out the license situation.
We already have the nonoss profile, so this is a pretty good fix for
the windows build issues noted above IMO.
Damoder/Koushik - please make this change.
Something similar is true by the way (IMHO, but as a project
cloudstack can definitely decide differently), for a possible MSI
script. Making an MSI script that prompts the user whether to
download mysql at the point of install, **clearly pointing out the
license situation** if they choose to do so, seems reasonable, and I
personally would not object to shipping _that_ kind of script as part of an apache source release.
+1 - that's a reasonable approach as well. Damoder / Koushik - what
+do
you think about this approach?
I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
Finally, the _spirit_ behind the apache policies is that there should
be an option to use cloudstack with a license-compatible database
(say, postgres), even if most users will use mysql (just like most
people that use dbm with httpd will use berkely dbm, but you _can_
use something else). Itąs perhaps unfortunate that this isnąt
supported, but thatąs not apache policy, and given the license
situation of other system dependencies, I can imagine no-one here wants to make it a priority.
Yeah, that would be nice... but somebody would have to decide that
they want to do that.
cheers,
Leo
PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
is about choice/policy, and the policy is supposed to be based on
common sense much more than license stuff tends to be :)
Agreed - this is about policy not legality.
RE: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Damoder Reddy <Da...@citrix.com>.
Ok,
To clarify the windows MSI will not build in the default profile. I have enabled a new profile "buildw" to build windows MSI installer which explicitly we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss profile explicitly?
Thanks
Damoder/
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: dev@cloudstack.apache.org
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org> wrote:
> On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
>> It looks like that maven pom on windows _by default_ downloads and
>> installs a variety of non-apache-license (and/or non-mit/bsd/variant
>> license) software. That shouldnąt really happen. The principle is one
>> of łleast surprise˛: As a user or developer who does not RTFM,
>> following the default commands/tools/etc, you should end up with a
>> more-or-less apache-licensed build result (*) that you can
>> redistribute the result under.
>
> +1
>
>>
>> But apache policy is that it is acceptable to provide scripts/build
>> tools/assistance to help those same users/developers do things that
>> they want to do. As long as they understand the legal situation they end up in.
>>
>> I would recommend adding a "nonoss" maven profile that the
>> developer/user has to explicitly select in order to do those
>> downloads. As long as that option is described clearly, thatąs then
>> ok. See
>>
>> http://svn.apache.org/repos/asf/apr/apr/trunk/README
>>
>> for an example of how to point out the license situation.
>
> We already have the nonoss profile, so this is a pretty good fix for
> the windows build issues noted above IMO.
>
> Damoder/Koushik - please make this change.
>
>>
>> Something similar is true by the way (IMHO, but as a project
>> cloudstack can definitely decide differently), for a possible MSI
>> script. Making an MSI script that prompts the user whether to
>> download mysql at the point of install, **clearly pointing out the
>> license situation** if they choose to do so, seems reasonable, and I
>> personally would not object to shipping _that_ kind of script as part of an apache source release.
>>
>
> +1 - that's a reasonable approach as well. Damoder / Koushik - what
> +do
> you think about this approach?
>
I like this approach. We have a number of things that aren't in the 'default' build because of policy reasons. This is just another of them.
>> Finally, the _spirit_ behind the apache policies is that there should
>> be an option to use cloudstack with a license-compatible database
>> (say, postgres), even if most users will use mysql (just like most
>> people that use dbm with httpd will use berkely dbm, but you _can_
>> use something else). Itąs perhaps unfortunate that this isnąt
>> supported, but thatąs not apache policy, and given the license
>> situation of other system dependencies, I can imagine no-one here wants to make it a priority.
>
> Yeah, that would be nice... but somebody would have to decide that
> they want to do that.
>
>>
>>
>> cheers,
>>
>>
>> Leo
>>
>> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and
>> is about choice/policy, and the policy is supposed to be based on
>> common sense much more than license stuff tends to be :)
>
> Agreed - this is about policy not legality.
>
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by David Nalley <da...@gnsa.us>.
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers <ch...@apache.org> wrote:
> On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
>> It looks like that maven pom on windows _by default_ downloads and
>> installs a variety of non-apache-license (and/or non-mit/bsd/variant
>> license) software. That shouldnąt really happen. The principle is one of
>> łleast surprise˛: As a user or developer who does not RTFM, following the
>> default commands/tools/etc, you should end up with a more-or-less
>> apache-licensed build result (*) that you can redistribute the result
>> under.
>
> +1
>
>>
>> But apache policy is that it is acceptable to provide scripts/build
>> tools/assistance to help those same users/developers do things that they
>> want to do. As long as they understand the legal situation they end up in.
>>
>> I would recommend adding a "nonoss" maven profile that the developer/user
>> has to explicitly select in order to do those downloads. As long as that
>> option is described clearly, thatąs then ok. See
>>
>> http://svn.apache.org/repos/asf/apr/apr/trunk/README
>>
>> for an example of how to point out the license situation.
>
> We already have the nonoss profile, so this is a pretty good fix for the
> windows build issues noted above IMO.
>
> Damoder/Koushik - please make this change.
>
>>
>> Something similar is true by the way (IMHO, but as a project cloudstack
>> can definitely decide differently), for a possible MSI script. Making an
>> MSI script that prompts the user whether to download mysql at the point of
>> install, **clearly pointing out the license situation** if they choose to
>> do so, seems reasonable, and I personally would not object to shipping
>> _that_ kind of script as part of an apache source release.
>>
>
> +1 - that's a reasonable approach as well. Damoder / Koushik - what do
> you think about this approach?
>
I like this approach. We have a number of things that aren't in the
'default' build because of policy reasons. This is just another of
them.
>> Finally, the _spirit_ behind the apache policies is that there should be
>> an option to use cloudstack with a license-compatible database (say,
>> postgres), even if most users will use mysql (just like most people that
>> use dbm with httpd will use berkely dbm, but you _can_ use something
>> else). Itąs perhaps unfortunate that this isnąt supported, but thatąs not
>> apache policy, and given the license situation of other system
>> dependencies, I can imagine no-one here wants to make it a priority.
>
> Yeah, that would be nice... but somebody would have to decide that they
> want to do that.
>
>>
>>
>> cheers,
>>
>>
>> Leo
>>
>> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and is
>> about choice/policy, and the policy is supposed to be based on common
>> sense much more than license stuff tends to be :)
>
> Agreed - this is about policy not legality.
>
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Chip Childers <ch...@apache.org>.
On Thu, Jul 03, 2014 at 03:14:30PM +0000, Leo Simons wrote:
> It looks like that maven pom on windows _by default_ downloads and
> installs a variety of non-apache-license (and/or non-mit/bsd/variant
> license) software. That shouldn¹t really happen. The principle is one of
> ³least surprise²: As a user or developer who does not RTFM, following the
> default commands/tools/etc, you should end up with a more-or-less
> apache-licensed build result (*) that you can redistribute the result
> under.
+1
>
> But apache policy is that it is acceptable to provide scripts/build
> tools/assistance to help those same users/developers do things that they
> want to do. As long as they understand the legal situation they end up in.
>
> I would recommend adding a "nonoss" maven profile that the developer/user
> has to explicitly select in order to do those downloads. As long as that
> option is described clearly, that¹s then ok. See
>
> http://svn.apache.org/repos/asf/apr/apr/trunk/README
>
> for an example of how to point out the license situation.
We already have the nonoss profile, so this is a pretty good fix for the
windows build issues noted above IMO.
Damoder/Koushik - please make this change.
>
> Something similar is true by the way (IMHO, but as a project cloudstack
> can definitely decide differently), for a possible MSI script. Making an
> MSI script that prompts the user whether to download mysql at the point of
> install, **clearly pointing out the license situation** if they choose to
> do so, seems reasonable, and I personally would not object to shipping
> _that_ kind of script as part of an apache source release.
>
+1 - that's a reasonable approach as well. Damoder / Koushik - what do
you think about this approach?
> Finally, the _spirit_ behind the apache policies is that there should be
> an option to use cloudstack with a license-compatible database (say,
> postgres), even if most users will use mysql (just like most people that
> use dbm with httpd will use berkely dbm, but you _can_ use something
> else). It¹s perhaps unfortunate that this isn¹t supported, but that¹s not
> apache policy, and given the license situation of other system
> dependencies, I can imagine no-one here wants to make it a priority.
Yeah, that would be nice... but somebody would have to decide that they
want to do that.
>
>
> cheers,
>
>
> Leo
>
> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and is
> about choice/policy, and the policy is supposed to be based on common
> sense much more than license stuff tends to be :)
Agreed - this is about policy not legality.
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Leo Simons <LS...@schubergphilis.com>.
Heya,
On 7/3/14, 4:11 PM, "Chip Childers" <ch...@apache.org> wrote:
>On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote:
>>
>> On to the actual point behind my comment, ASF policy is not very clear
>> about when we can or can¹t put anything in our code that points to
>> something with a (L)GPL license. I would like some feedback from
>> people with a finer grasp of the policy to see if we can actually
>> include this dependency on mysql and the mysql connection in our wix
>> script.
>>
>> Cheers,
>>
>> Hugo
>
>This is a bit tricky (and splitting hairs)... Obviously all of this is
>based on my understanding of past discussions and the relevant policies
>/ licenses... but INAL and certainly not an expert here. Comments /
>disagreements welcome.
>
>
>In a non-platform specific sense, we have said that the MySQL
>connector jar file is a *system dependency*.
>...
>For the non-developer profiles, it is expected that mysql connector is
>already on your system prior to using the software.
>...
>Now, we DO provide scripts to help downstream projects and users build
>packages:
>..
>Now, dealing with the whole MSI thing (including the specific review in
>question, but also looking in other places related to the MSI), we have
>a different situation.
>
>*MySQL Itself*
>First, we are specifically taking action to download and install MySQL.
>This has to be taken out IMO, since it's quite a bit different from
>saying "here's a system package we expect to be there, like java
>itself". Since Windows doesn't have "package management" that pulls
>from a central repo, I understand why the download is there... but I'm
>-1 on it being in a release.
>
>*MySQL Connector*
>I see that we are doing the same thing with the connector in the pom
>files and the MSI - explicitly pulling it into the system.
Yup, this is all spot on. For reference, mysql has been discussed _a lot_
in the past
http://apache.markmail.org/search/?q=mysql+list%3Aorg.apache.legal-discuss
>I'll defer to someone else about the specifics of that in the pom files,
>because I'm not a maven guy that knows what exactly is ocurring there.
>Can someone review and talk about how that directive behaves (and
>compare / contrast with the developer profiles)?
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldn¹t really happen. The principle is one of
³least surprise²: As a user or developer who does not RTFM, following the
default commands/tools/etc, you should end up with a more-or-less
apache-licensed build result (*) that you can redistribute the result
under.
But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that they
want to do. As long as they understand the legal situation they end up in.
I would recommend adding a "nonoss" maven profile that the developer/user
has to explicitly select in order to do those downloads. As long as that
option is described clearly, that¹s then ok. See
http://svn.apache.org/repos/asf/apr/apr/trunk/README
for an example of how to point out the license situation.
Something similar is true by the way (IMHO, but as a project cloudstack
can definitely decide differently), for a possible MSI script. Making an
MSI script that prompts the user whether to download mysql at the point of
install, **clearly pointing out the license situation** if they choose to
do so, seems reasonable, and I personally would not object to shipping
_that_ kind of script as part of an apache source release.
Finally, the _spirit_ behind the apache policies is that there should be
an option to use cloudstack with a license-compatible database (say,
postgres), even if most users will use mysql (just like most people that
use dbm with httpd will use berkely dbm, but you _can_ use something
else). It¹s perhaps unfortunate that this isn¹t supported, but that¹s not
apache policy, and given the license situation of other system
dependencies, I can imagine no-one here wants to make it a priority.
cheers,
Leo
PS: IANAL, but, a lot of this discussion is a bit beyond legal, and is
about choice/policy, and the policy is supposed to be based on common
sense much more than license stuff tends to be :)
(*) technically, LICENSE-file-licensed result, which could include BSD,
MIT, and a bunch of other such compatible license terms
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Chip Childers <ch...@apache.org>.
On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote:
>
> On to the actual point behind my comment, ASF policy is not very clear
> about when we can or can’t put anything in our code that points to
> something with a (L)GPL license. I would like some feedback from
> people with a finer grasp of the policy to see if we can actually
> include this dependency on mysql and the mysql connection in our wix
> script.
>
> Cheers,
>
> Hugo
This is a bit tricky (and splitting hairs)... Obviously all of this is
based on my understanding of past discussions and the relevant policies
/ licenses... but INAL and certainly not an expert here. Comments /
disagreements welcome.
In a non-platform specific sense, we have said that the MySQL
connector jar file is a *system dependency*. Meaning... for our
software to work, it needs to be installed by the user on the system
before-hand.
We have allowed it to be downloaded in certain maven profiles
(specifically, IIRC, developer-centric profiles), as a convenience only
(since those profiles aren't required for normal users).
For the non-developer profiles, it is expected that mysql connector is
already on your system prior to using the software.
Above is all about users building from source, based on what we
officially release....
Now, we DO provide scripts to help downstream projects and users build
packages:
Our DEB/RPM packaging scripts *do* reference this dependency. Since the
project itself does *not* distribute packages, and since packages are
designed to specify *system dependencies*, we believe this satisfies the
ASF policies. OpenJDK is also a *system dependency* that we specify in
our packages, and nobody would be confused about us expecting java to
exist on the target environment for our software to work. (This was
discussed with mentors back during incubation, but I can't seem to find
the relevant links at the moment.)
We do *NOT* include MySQL itself in our package scripts, only the
connector.
Now, dealing with the whole MSI thing (including the specific review in
question, but also looking in other places related to the MSI), we have
a different situation.
*MySQL Itself*
First, we are specifically taking action to download and install MySQL.
This has to be taken out IMO, since it's quite a bit different from
saying "here's a system package we expect to be there, like java
itself". Since Windows doesn't have "package management" that pulls
from a central repo, I understand why the download is there... but I'm
-1 on it being in a release.
*MySQL Connector*
I see that we are doing the same thing with the connector in the pom
files and the MSI - explicitly pulling it into the system.
I'll defer to someone else about the specifics of that in the pom files,
because I'm not a maven guy that knows what exactly is ocurring there.
Can someone review and talk about how that directive behaves (and
compare / contrast with the developer profiles)?
In the packaging, same problem as MySQL... we are explicitly
downloading GPL code. That also needs to be removed IMO. I'm -1 on
that being in the codebase.
Unfortunately, I *think* that we need to document MySQL and MySQL
Connector.jar installations are being pre-requisites to installing ACS
from an MSI. If a *downstream* project / product wants to include them
in an installer, fine... but the Apache CloudStack project needs to
remove them and add them as documented pre-requisites.
-chip
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
Posted by Hugo Trippaers <hu...@apache.org>.
On to the actual point behind my comment, ASF policy is not very clear about when we can or can’t put anything in our code that points to something with a (L)GPL license. I would like some feedback from people with a finer grasp of the policy to see if we can actually include this dependency on mysql and the mysql connection in our wix script.
Cheers,
Hugo
On 3 jul. 2014, at 14:33, Hugo Trippaers <hu...@apache.org> wrote:
> Hey Koushik,
>
> No problem, will do if required.
>
> The review doesn’t have a “ship it” state, so thats why i assumed it was not committed. Also a lot of folks adopted the common practice to put the commit id in a comment after committing a review. That makes it easier to trace.
>
> Cheers,
>
> Hugo
>
>
> On 3 jul. 2014, at 14:29, Koushik Das <ko...@citrix.com> wrote:
>
>>
>>
>>> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
>>>> I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch.
>>
>> Hugo, I committed this patch (on master ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this comment from you. If there is going to be a license issue then please feel free to revert.
>>
>>
>> - Koushik
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23192/#review47289
>> -----------------------------------------------------------
>>
>>
>> On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/23192/
>>> -----------------------------------------------------------
>>>
>>> (Updated July 3, 2014, 11:58 a.m.)
>>>
>>>
>>> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>>>
>>>
>>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>>
>>>
>>> Repository: cloudstack-git
>>>
>>>
>>> Description
>>> -------
>>>
>>> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>>>
>>>
>>> Diffs
>>> -----
>>>
>>> client/pom.xml 29fef4f
>>> pom.xml 0b3b56e
>>> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
>>> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
>>> scripts/installer/windows/acs.wxs bf09afc
>>> scripts/installer/windows/dependencies.wxs 987c561
>>> scripts/installer/windows/en-us.wxl 2f34575
>>> scripts/installer/windows/optionstheme_en-us.wxl c822929
>>> scripts/installer/windows/readme.txt PRE-CREATION
>>>
>>> Diff: https://reviews.apache.org/r/23192/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Tested on Windows 2012 Server
>>>
>>>
>>> Thanks,
>>>
>>> Damodar Reddy Talakanti
>>>
>>>
>>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Chip Childers <ch...@apache.org>.
On Thu, Jul 03, 2014 at 01:37:27PM +0000, Koushik Das wrote:
> I was about to give the "ship it" and then saw your comment. Anyways have done it now.
We are likely to need to revert (or at least change through a new
commit) a bunch of things introduced within the pom and msi files. See
my last email on the topic.
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Koushik Das <ko...@citrix.com>.
I was about to give the "ship it" and then saw your comment. Anyways have done it now.
On 03-Jul-2014, at 6:03 PM, Hugo Trippaers <hu...@apache.org> wrote:
> Hey Koushik,
>
> No problem, will do if required.
>
> The review doesn’t have a “ship it” state, so thats why i assumed it was not committed. Also a lot of folks adopted the common practice to put the commit id in a comment after committing a review. That makes it easier to trace.
>
> Cheers,
>
> Hugo
>
>
> On 3 jul. 2014, at 14:29, Koushik Das <ko...@citrix.com> wrote:
>
>>
>>
>>> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
>>>> I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch.
>>
>> Hugo, I committed this patch (on master ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this comment from you. If there is going to be a license issue then please feel free to revert.
>>
>>
>> - Koushik
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23192/#review47289
>> -----------------------------------------------------------
>>
>>
>> On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/23192/
>>> -----------------------------------------------------------
>>>
>>> (Updated July 3, 2014, 11:58 a.m.)
>>>
>>>
>>> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>>>
>>>
>>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>>
>>>
>>> Repository: cloudstack-git
>>>
>>>
>>> Description
>>> -------
>>>
>>> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>>>
>>>
>>> Diffs
>>> -----
>>>
>>> client/pom.xml 29fef4f
>>> pom.xml 0b3b56e
>>> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
>>> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
>>> scripts/installer/windows/acs.wxs bf09afc
>>> scripts/installer/windows/dependencies.wxs 987c561
>>> scripts/installer/windows/en-us.wxl 2f34575
>>> scripts/installer/windows/optionstheme_en-us.wxl c822929
>>> scripts/installer/windows/readme.txt PRE-CREATION
>>>
>>> Diff: https://reviews.apache.org/r/23192/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Tested on Windows 2012 Server
>>>
>>>
>>> Thanks,
>>>
>>> Damodar Reddy Talakanti
>>>
>>>
>>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector
Posted by Hugo Trippaers <hu...@apache.org>.
Hey Koushik,
No problem, will do if required.
The review doesn’t have a “ship it” state, so thats why i assumed it was not committed. Also a lot of folks adopted the common practice to put the commit id in a comment after committing a review. That makes it easier to trace.
Cheers,
Hugo
On 3 jul. 2014, at 14:29, Koushik Das <ko...@citrix.com> wrote:
>
>
>> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
>>> I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch.
>
> Hugo, I committed this patch (on master ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this comment from you. If there is going to be a license issue then please feel free to revert.
>
>
> - Koushik
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/#review47289
> -----------------------------------------------------------
>
>
> On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23192/
>> -----------------------------------------------------------
>>
>> (Updated July 3, 2014, 11:58 a.m.)
>>
>>
>> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>>
>>
>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>>
>>
>> Diffs
>> -----
>>
>> client/pom.xml 29fef4f
>> pom.xml 0b3b56e
>> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
>> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
>> scripts/installer/windows/acs.wxs bf09afc
>> scripts/installer/windows/dependencies.wxs 987c561
>> scripts/installer/windows/en-us.wxl 2f34575
>> scripts/installer/windows/optionstheme_en-us.wxl c822929
>> scripts/installer/windows/readme.txt PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/23192/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested on Windows 2012 Server
>>
>>
>> Thanks,
>>
>> Damodar Reddy Talakanti
>>
>>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Koushik Das <ko...@citrix.com>.
> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
> > I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch.
Hugo, I committed this patch (on master ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this comment from you. If there is going to be a license issue then please feel free to revert.
- Koushik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47289
-----------------------------------------------------------
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47289
-----------------------------------------------------------
I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept this patch.
- Hugo Trippaers
On July 3, 2014, 10:22 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 10:22 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47300
-----------------------------------------------------------
Ship it!
master -> ce5061e107f743e52b23445fd97fcf60d8160ec6
- Koushik Das
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review78993
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end
of the installation. Also installing mysql connector
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review64046
-----------------------------------------------------------
ping, any update on this?
- Rohit Yadav
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Koushik Das <ko...@citrix.com>.
> On July 3, 2014, 2:18 p.m., Chip Childers wrote:
> > -1 to this commit until legal policy issues are resolved
Reverted the commit
commit 4607c26949b6b925fdc0eb2a5253d536dd333439
Author: Koushik Das <ko...@apache.org>
Date: Fri Jul 4 10:04:04 2014 +0530
Revert "CLOUDSTACK-6834 : 3. Some description changes words like CloudStack etc 4. Change Default installation location if possible include version number 5. Mysql Connector Installer along with oth
This reverts commit ce5061e107f743e52b23445fd97fcf60d8160ec6.
- Koushik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47301
-----------------------------------------------------------
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47301
-----------------------------------------------------------
-1 to this commit until legal policy issues are resolved
- Chip Childers
On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> pom.xml 0b3b56e
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
-----------------------------------------------------------
(Updated July 3, 2014, 11:58 a.m.)
Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo Trippaers.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
Repository: cloudstack-git
Description
-------
Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
Diffs
-----
client/pom.xml 29fef4f
pom.xml 0b3b56e
scripts/installer/windows/ExitDialog.wxs PRE-CREATION
scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
scripts/installer/windows/acs.wxs bf09afc
scripts/installer/windows/dependencies.wxs 987c561
scripts/installer/windows/en-us.wxl 2f34575
scripts/installer/windows/optionstheme_en-us.wxl c822929
scripts/installer/windows/readme.txt PRE-CREATION
Diff: https://reviews.apache.org/r/23192/diff/
Testing
-------
Tested on Windows 2012 Server
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
-----------------------------------------------------------
(Updated July 3, 2014, 10:22 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
Ignored readme.txt from rat build
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
Repository: cloudstack-git
Description
-------
Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
Diffs (updated)
-----
client/pom.xml 29fef4f
pom.xml 0b3b56e
scripts/installer/windows/ExitDialog.wxs PRE-CREATION
scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
scripts/installer/windows/acs.wxs bf09afc
scripts/installer/windows/dependencies.wxs 987c561
scripts/installer/windows/en-us.wxl 2f34575
scripts/installer/windows/optionstheme_en-us.wxl c822929
scripts/installer/windows/readme.txt PRE-CREATION
Diff: https://reviews.apache.org/r/23192/diff/
Testing
-------
Tested on Windows 2012 Server
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47280
-----------------------------------------------------------
scripts/installer/windows/readme.txt
<https://reviews.apache.org/r/23192/#comment82951>
License header?
- Koushik Das
On July 2, 2014, 12:29 p.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> -----------------------------------------------------------
>
> (Updated July 2, 2014, 12:29 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
>
>
> Diffs
> -----
>
> client/pom.xml 29fef4f
> scripts/installer/windows/ExitDialog.wxs PRE-CREATION
> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
> scripts/installer/windows/acs.wxs bf09afc
> scripts/installer/windows/dependencies.wxs 987c561
> scripts/installer/windows/en-us.wxl 2f34575
> scripts/installer/windows/optionstheme_en-us.wxl c822929
> scripts/installer/windows/readme.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23192/diff/
>
>
> Testing
> -------
>
> Tested on Windows 2012 Server
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23192: Adding Readme and run checkbox at the end of the
installation. Also installing mysql connector
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
-----------------------------------------------------------
(Updated July 2, 2014, 12:29 p.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
Repository: cloudstack-git
Description (updated)
-------
Incorporated some Changes to include things like runservice readme checkbox, changing the default installation location etc..
Diffs
-----
client/pom.xml 29fef4f
scripts/installer/windows/ExitDialog.wxs PRE-CREATION
scripts/installer/windows/WixInstallerDialog.wxs 0282d8a
scripts/installer/windows/acs.wxs bf09afc
scripts/installer/windows/dependencies.wxs 987c561
scripts/installer/windows/en-us.wxl 2f34575
scripts/installer/windows/optionstheme_en-us.wxl c822929
scripts/installer/windows/readme.txt PRE-CREATION
Diff: https://reviews.apache.org/r/23192/diff/
Testing
-------
Tested on Windows 2012 Server
Thanks,
Damodar Reddy Talakanti