You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/30 17:00:10 UTC

[GitHub] mgaido91 opened a new pull request #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause

mgaido91 opened a new pull request #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause
URL: https://github.com/apache/spark/pull/23701
 
 
   ## What changes were proposed in this pull request?
   
   When an `AggergateExpression` is used in a `Sort` operator and the sort operator is not immediately after an `Aggregate` plan, the expression is left as is in the sort operator by the Analyzer. This generates a bad plan which fails at execution.
   
   The PR rewrites `AggergateExpression` in `Sort`, also when the `Aggregate` is not a direct child.
   
   ## How was this patch tested?
   
   added UT and re-enabled UT
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org