You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/30 22:31:15 UTC

[GitHub] [airflow] joseph-max-coalfire opened a new issue, #26812: Add NodePort Option to the values schema

joseph-max-coalfire opened a new issue, #26812:
URL: https://github.com/apache/airflow/issues/26812

   ### Official Helm Chart version
   
   1.6.0 (latest released)
   
   ### Apache Airflow version
   
   2.3.4
   
   ### Kubernetes Version
   
   1.23
   
   ### Helm Chart configuration
   
   # shortened values.yaml file  
   webserver:
       service:
         type: NodePort
         ports:
           - name: airflow-ui
             port: 80
             targetPort: airflow-ui
             nodePort: 8081  # Note this line does not work, this is what'd be nice to have for defining nodePort
   
   ### Docker Image customisations
   
   _No response_
   
   ### What happened
   
   Supplying nodePort like in the above Helm Chart Configuration example fails with an error saying a value of nodePort is not supported.
   
   ### What you think should happen instead
   
   It'd be nice if we could define the nodePort we want the airflow-webserver service to listen on at launch. As it currently stands, supplying nodePort like in the above values.yaml example will fail, saying nodePort cannot be supplied. The workaround is to manually edit the webserver service post-deployment and specify the desired nodePort.
   
   I looked at the way [the webserver service template file](https://github.com/apache/airflow/blob/main/chart/templates/webserver/webserver-service.yaml#L44-L50) is set up, and the logic there should allow this, but I believe the missing definition in the [schema.json](https://github.com/apache/airflow/blob/main/chart/values.schema.json#L3446-L3472) file is causing this to error out. 
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #26812: Add NodePort Option to the values schema

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #26812:
URL: https://github.com/apache/airflow/issues/26812#issuecomment-1264089917

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #26812: Add NodePort Option to the values schema

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #26812:
URL: https://github.com/apache/airflow/issues/26812#issuecomment-1264502101

   Feel free.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #26812: Add NodePort Option to the values schema

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #26812: Add NodePort Option to the values schema
URL: https://github.com/apache/airflow/issues/26812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org