You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/20 14:22:24 UTC
[GitHub] [airflow] vincbeck commented on a diff in pull request #27149: Fix example_emr_serverless system test
vincbeck commented on code in PR #27149:
URL: https://github.com/apache/airflow/pull/27149#discussion_r1000703520
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -220,7 +220,7 @@ def check_for_bucket(self, bucket_name: str | None = None) -> bool:
# https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.head_bucket
return_code = int(e.response['Error']['Code'])
if return_code == 404:
- self.log.error('Bucket "%s" does not exist', bucket_name)
+ self.log.info('Bucket "%s" does not exist', bucket_name)
Review Comment:
Well. If it's 403 the bucket exists but the user does not have permissions so I think it makes sense to log an error for that use case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org