You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/02/02 08:37:00 UTC
[jira] [Commented] (MRESOLVER-317) Improvements for BF collector
[ https://issues.apache.org/jira/browse/MRESOLVER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683267#comment-17683267 ]
ASF GitHub Bot commented on MRESOLVER-317:
------------------------------------------
cstamas opened a new pull request, #238:
URL: https://github.com/apache/maven-resolver/pull/238
Changes:
* make skipper closeable
* make parallel descriptor resolver closeable
* the two above should be used within try-with-resource block
* improve encapsulation of resolver
---
https://issues.apache.org/jira/browse/MRESOLVER-317
> Improvements for BF collector
> -----------------------------
>
> Key: MRESOLVER-317
> URL: https://issues.apache.org/jira/browse/MRESOLVER-317
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.5
>
>
> The BF collector should receive following improvements:
> * make skipper Closeable
> * make ParallelDescriptorResolver Closeable
> * improve encapsulation of ParallelDescriptorResolver (make fields private final)
> * the doCollectDependencies method should use the two closeables within try-with-resource block
> Currently there may be resource leak (thread pool) if doCollectDependencies method throws, as resolver will not be shut down (skipper does not hold resources, but logic is same).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)