[GitHub] [hbase] wchevreuil commented on a change in pull request #3932: HBASE-26556 IT and Chaos Monkey improvements

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #3932:
URL: https://github.com/apache/hbase/pull/3932#discussion_r768717542



##########
File path: hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java
##########
@@ -216,7 +217,7 @@ protected String findPidCommand(ServiceType service) {
     }
 
     public String signalCommand(ServiceType service, String signal) {
-      return String.format("%s | xargs kill -s %s", findPidCommand(service), signal);
+      return String.format("%s | xargs sudo kill -s %s", findPidCommand(service), signal);

Review comment:
       Yes. And the "findPidCommand" portion already assumes user has "sudo" access in order to obtain the hbase pid, so the command would't already work if the running user doesn't have sudo.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org