Re: [PR] [SPARK-48541][CORE] Add a new exit code for executors killed by TaskReaper [spark]

["JoshRosen (via GitHub)" <gi...@apache.org>]

JoshRosen commented on code in PR #46883:
URL: https://github.com/apache/spark/pull/46883#discussion_r1645244221


##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -1310,3 +1309,5 @@ private[spark] object Executor {
     }
   }
 }
+
+class KilledByTaskReaperException(message: String) extends SparkException(message)

Review Comment:
   Makes sense: this is effectively a control flow exception.



##########
core/src/main/scala/org/apache/spark/executor/ExecutorExitCode.scala:
##########
@@ -45,6 +45,10 @@ object ExecutorExitCode {
    */
   val HEARTBEAT_FAILURE = 56
 
+  /** The default uncaught exception handler was reached and the exception was thrown by
+   * TaskReaper. */
+  val KILLED_BY_TASK_REAPER = 57
+
   def explainExitCode(exitCode: Int): String = {

Review Comment:
   @bozhang2820, actually, whoops, I had overlooked this, but it looks like we should probably add a new case to `explainExitCode` here for the new `KILLED_BY_TASK_REAPER`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org