[GitHub] [pinot] gortiz commented on a diff in pull request #10411: Retry segment untar failures

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on code in PR #10411:
URL: https://github.com/apache/pinot/pull/10411#discussion_r1133713418


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -644,12 +659,13 @@ private File downloadAndStreamUntarWithRateLimit(String segmentName, SegmentZKMe
   }
 
   @VisibleForTesting
-  File untarAndMoveSegment(String segmentName, File tarFile, File tempRootDir)
+  protected File untarAndMoveSegment(String segmentName, File tarFile, File tempRootDir)
       throws IOException {
     File untarDir = new File(tempRootDir, segmentName);
     try {
       // If an exception is thrown when untarring, it means the tar file is broken
       // or not found after the retry. Thus, there's no need to retry again.
+      // unless untar retry is configured, which will retry this function call

Review Comment:
   The original description says that there is no need to retry, implying that if it fails once, retries will also fail. In which cases a retry will be useful?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org