Re: [PR] HIVE-25043: Addendum: Support custom UDF in Vectorized mode [hive]

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #5703:
URL: https://github.com/apache/hive/pull/5703#discussion_r2093357929


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java:
##########
@@ -2411,6 +2415,39 @@ private boolean getOnlyStructObjectInspectors(ReduceWork reduceWork,
     }
   }
 
+  private void addCustomUDFs(HiveConf hiveConf) {
+    if (hiveConf == null) {
+      return;
+    }
+
+    String[] udfs =
+        HiveConf.getTrimmedStringsVar(hiveConf, HiveConf.ConfVars.HIVE_VECTOR_ADAPTOR_CUSTOM_UDF_WHITELIST);
+    if (udfs == null) {
+      return;
+    }
+
+    HiveVectorAdaptorUsageMode hiveVectorAdaptorUsageMode =
+        HiveVectorAdaptorUsageMode.getHiveConfValue(hiveConf);
+    if (hiveVectorAdaptorUsageMode != HiveVectorAdaptorUsageMode.CHOSEN &&

Review Comment:
   Why do we add custom UDFs for `HiveVectorAdaptorUsageMode.ALL` mode?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org