You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/14 03:55:17 UTC

[GitHub] [rocketmq-exporter] zhangspook opened a new issue, #114: rocketmq_broker_tps

zhangspook opened a new issue, #114:
URL: https://github.com/apache/rocketmq-exporter/issues/114

   rocketmq_broker_tps | Broker produces the number of messages per second
   rocketmq_producer_tps | The number of messages produced per second per topic
   
   Whether to divide by 60 seconds
   
   for example
   
   "rocketmq_broker_tps / 60"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-exporter] sinrimin commented on issue #114: rocketmq_broker_tps

Posted by GitBox <gi...@apache.org>.
sinrimin commented on issue #114:
URL: https://github.com/apache/rocketmq-exporter/issues/114#issuecomment-1293220867

   我想问题出在 `rocketmq_producer_tps` 使用的是 `BrokerStatsData.getStatsMinute().getSum()`
   ```java
               try {
                   bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.BROKER_PUT_NUMS, clusterName);
                   metricsService.getCollector().addBrokerPutNumsMetric(
                       clusterName,
                       brokerIP,
                       brokerName,
                       Utils.getFixedDouble(bsd.getStatsMinute().getSum()));
               } catch (MQClientException ex) {
                   if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
                       // log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
                   } else {
                       log.error(String.format("BROKER_PUT_NUMS-error,  master broker=%s", masterAddr), ex);
                   }
               } catch (Exception ex) {
                   log.error(String.format("BROKER_PUT_NUMS-error, master broker=%s", masterAddr), ex);
               }
   ```
   而 `rocketmq_broker_qps` 使用的是 `BrokerStatsData.getStatsMinute().getTps()`
   ```java
               try {
                   bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.BROKER_GET_NUMS, clusterName);
                   metricsService.getCollector().addBrokerGetNumsMetric(
                       clusterName,
                       brokerIP,
                       brokerName,
                       Utils.getFixedDouble(bsd.getStatsMinute().getTps()));
               } catch (MQClientException ex) {
                   if (ex.getResponseCode() == ResponseCode.SYSTEM_ERROR) {
                       // log.error(String.format("GROUP_GET_SIZE-error, topic=%s, group=%s, master broker=%s, %s", topic, group, masterAddr, ex.getErrorMessage()));
                   } else {
                       log.error(String.format("BROKER_GET_NUMS-error,  master broker=%s", masterAddr), ex);
                   }
               } catch (Exception ex) {
                   log.error(String.format("BROKER_GET_NUMS-error, master broker=%s", masterAddr), ex);
               }
   ```
   另外 `rocketmq_consumer_tps`  也要除 60,原因不明


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-exporter] cserwen commented on issue #114: rocketmq_broker_tps

Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on issue #114:
URL: https://github.com/apache/rocketmq-exporter/issues/114#issuecomment-1581783392

   最早的版本就是 TPS,使用的`getTps()`,#108 改成了 getSum,理论上应该增加个指标叫 tpm,我觉得我们应该改回来 @zhangspook  @qiuq198 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-exporter] zhangspook closed issue #114: rocketmq_broker_tps

Posted by "zhangspook (via GitHub)" <gi...@apache.org>.
zhangspook closed issue #114: rocketmq_broker_tps 
URL: https://github.com/apache/rocketmq-exporter/issues/114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-exporter] zhangspook commented on issue #114: rocketmq_broker_tps

Posted by GitBox <gi...@apache.org>.
zhangspook commented on issue #114:
URL: https://github.com/apache/rocketmq-exporter/issues/114#issuecomment-1293582703

   应该是TPM,但是确实没有改全


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-exporter] qiuq198 commented on issue #114: rocketmq_broker_tps

Posted by GitBox <gi...@apache.org>.
qiuq198 commented on issue #114:
URL: https://github.com/apache/rocketmq-exporter/issues/114#issuecomment-1317983913

   should we change into tps ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-exporter] zhangspook commented on issue #114: rocketmq_broker_tps

Posted by "zhangspook (via GitHub)" <gi...@apache.org>.
zhangspook commented on issue #114:
URL: https://github.com/apache/rocketmq-exporter/issues/114#issuecomment-1637280353

   get


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org