You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/20 05:46:48 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue #11918: 'HINT_INLINE' sharding algorithm cannot take effect.
RaigorJiang opened a new issue #11918:
URL: https://github.com/apache/shardingsphere/issues/11918
## Bug Report
### Which version of ShardingSphere did you use?
master branch
### Problem
Use `HINT_INLINE` sharding algorithm, but `algorithm-expression` cannot take effect.
### Reason analyze (If you can)
Class `HintInlineShardingAlgorithm` implements `TypedSPI`, and the properties value is assigned via `setProps` method like in `InlineShardingAlgorithm`.
However, in class `HintInlineShardingAlgorithm`, the name of the field `properties` does not match the `props` required by the interface.
### How to fix it
1. change field name `properties` to `props` in `HintInlineShardingAlgorithm`;
2. fix the `set` method name in `HintInlineShardingAlgorithmTest`;
For more process information, please refer to [Contributor Guide](https://shardingsphere.apache.org/community/en/contribute/contributor/) and code [Code of Conduct](https://shardingsphere.apache.org/community/en/contribute/code-conduct/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #11918: 'HINT_INLINE' sharding algorithm cannot take effect.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #11918:
URL: https://github.com/apache/shardingsphere/issues/11918#issuecomment-902466061
@Superainbower Welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #11918: 'HINT_INLINE' sharding algorithm cannot take effect.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #11918:
URL: https://github.com/apache/shardingsphere/issues/11918#issuecomment-902466937
@Superainbower
Welcome to contribute, if you have any questions, you can ask here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Superainbower commented on issue #11918: 'HINT_INLINE' sharding algorithm cannot take effect.
Posted by GitBox <gi...@apache.org>.
Superainbower commented on issue #11918:
URL: https://github.com/apache/shardingsphere/issues/11918#issuecomment-902465390
i want to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss closed issue #11918: 'HINT_INLINE' sharding algorithm cannot take effect.
Posted by GitBox <gi...@apache.org>.
menghaoranss closed issue #11918:
URL: https://github.com/apache/shardingsphere/issues/11918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org