You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/17 01:40:02 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3463: [Enhancement] Do some code optimization[EventmeshRebalanceImpl]

Alonexc opened a new issue, #3463:
URL: https://github.com/apache/incubator-eventmesh/issues/3463

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/225789107-c57774c4-4484-4784-bbf1-08aab96a0b37.png)
   ![image](https://user-images.githubusercontent.com/91315508/225789120-3908c395-cc74-4e25-a4e4-1b4ca27d099f.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java line 47,86,100,104,233,248,259,272
   analysis and explanation:
   Returning null instead of an actual array, collection or map forces callers of the method to explicitly test for nullity, making them more complex and less readable.
   Moreover, in many cases, null is used as a synonym for empty.
   
   
   ### Describe the solution you'd like
   
   a. add final
   ![image](https://user-images.githubusercontent.com/91315508/225789177-f8ffab15-47b7-40c1-98c4-8f01d3a98b5a.png)
   
   b. return an empty map instead of null
   ![image](https://user-images.githubusercontent.com/91315508/225789217-57dc48d8-6208-4349-a9ba-18cfe87edae0.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] xwm1992 closed issue #3463: [Enhancement] Do some code optimization[EventmeshRebalanceImpl]

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.

xwm1992 closed issue #3463: [Enhancement] Do some code optimization[EventmeshRebalanceImpl]
URL: https://github.com/apache/eventmesh/issues/3463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org