You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by wd...@apache.org on 2018/04/05 21:34:43 UTC
[3/5] kudu git commit: build-and-test.sh: unbreak Python 2.6 based
builds
build-and-test.sh: unbreak Python 2.6 based builds
The first beta of pip 10 was released several days ago, and it officially
drops support for Python 2.6, going so far as to use syntax that isn't
recognized by Python 2.6 interpreters. Let's address this by pinning to a
specific version of pip when upgrading (which, frankly, we should have done
a long time ago).
Note: pip supports environmental markers in version specifiers which we
could use to narrow this pinning such that it only takes effect if we're on
Python 2.6. However, the version of pip typically found in older distros is
old enough that it doesn't support environmental markers, so we'd need to do
two pip upgrades: the first to land on a version of pip that supports
markers, and the second to use the markers to conditionally upgrade to the
latest pip. This didn't seem worth the hassle.
Change-Id: I1afb5ba8169d193f502d3733fd3f826e9cb4ce6e
Reviewed-on: http://gerrit.cloudera.org:8080/9936
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/3d734055
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/3d734055
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/3d734055
Branch: refs/heads/master
Commit: 3d734055c2d9184fed3597dc7e08eed72c9a7ec7
Parents: 165688f
Author: Adar Dembo <ad...@cloudera.com>
Authored: Thu Apr 5 11:57:56 2018 -0700
Committer: Jean-Daniel Cryans <jd...@apache.org>
Committed: Thu Apr 5 20:16:18 2018 +0000
----------------------------------------------------------------------
build-support/jenkins/build-and-test.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/3d734055/build-support/jenkins/build-and-test.sh
----------------------------------------------------------------------
diff --git a/build-support/jenkins/build-and-test.sh b/build-support/jenkins/build-and-test.sh
index 12a2460..35fddb1 100755
--- a/build-support/jenkins/build-and-test.sh
+++ b/build-support/jenkins/build-and-test.sh
@@ -427,7 +427,11 @@ if [ "$BUILD_PYTHON" == "1" ]; then
# recursively to transitive dependencies installed via a direct dependency's
# "python setup.py" command. Therefore we have no choice but to upgrade to a
# new version of pip to proceed.
- pip install -i https://pypi.python.org/simple --upgrade pip
+ #
+ # Beginning with pip 10, Python 2.6 is no longer supported. Attempting to
+ # upgrade to pip 10 on Python 2.6 yields syntax errors. We don't need any new
+ # pip features, so let's pin to the last pip version to support Python 2.6.
+ pip install -i https://pypi.python.org/simple --upgrade 'pip < 10.0.0b1'
# New versions of pip raise an exception when upgrading old versions of
# setuptools (such as the one found in el6). The workaround is to upgrade