You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "David Leangen (JIRA)" <ji...@apache.org> on 2007/09/04 04:26:57 UTC

[jira] Created: (WICKET-922) Inconsistent use of Button vs. IFormSubmittingComponent

Inconsistent use of Button vs. IFormSubmittingComponent
-------------------------------------------------------

                 Key: WICKET-922
                 URL: https://issues.apache.org/jira/browse/WICKET-922
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.3.1
            Reporter: David Leangen


Inconsistent use of the new IFormSubmittingComponent interface.

Discussion here: http://www.nabble.com/Change-of-Button-interface-tf4370155.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-922) Inconsistent use of Button vs. IFormSubmittingComponent

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner resolved WICKET-922.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-beta4
         Assignee: Johan Compagner

applied the patch.

We could rename some methods but i think setDefaultButton is still a right name (from an UI perspective)
and now we don't break api, so i think this is ok.

> Inconsistent use of Button vs. IFormSubmittingComponent
> -------------------------------------------------------
>
>                 Key: WICKET-922
>                 URL: https://issues.apache.org/jira/browse/WICKET-922
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.3.1
>            Reporter: David Leangen
>            Assignee: Johan Compagner
>             Fix For: 1.3.0-beta4
>
>         Attachments: Form-Change_Button_to_IFormSubmittingComponent.diff
>
>
> Inconsistent use of the new IFormSubmittingComponent interface.
> Discussion here: http://www.nabble.com/Change-of-Button-interface-tf4370155.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-922) Inconsistent use of Button vs. IFormSubmittingComponent

Posted by "David Leangen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Leangen updated WICKET-922:
---------------------------------

    Attachment: Form-Change_Button_to_IFormSubmittingComponent.diff

Patch file.

The patch changes use of Button implementation for use of IFormSubmittingComponent interface.

In some of the methods, the IFormSubmittingComponent is cast to Component.

Comments and variable names are also updated to reflect the change.


Other than the change from Button to IFormSubmittingComponent, there are no other changes to the api. Therefore, some method names remain inconsistent (such as setDefaultButton, and so on).

> Inconsistent use of Button vs. IFormSubmittingComponent
> -------------------------------------------------------
>
>                 Key: WICKET-922
>                 URL: https://issues.apache.org/jira/browse/WICKET-922
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.3.1
>            Reporter: David Leangen
>         Attachments: Form-Change_Button_to_IFormSubmittingComponent.diff
>
>
> Inconsistent use of the new IFormSubmittingComponent interface.
> Discussion here: http://www.nabble.com/Change-of-Button-interface-tf4370155.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-922) Inconsistent use of Button vs. IFormSubmittingComponent

Posted by "David Leangen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524602 ] 

David Leangen commented on WICKET-922:
--------------------------------------

The following methods are used in Form, but are not defined in IFormSubmittingComponent:

  defaultButton.isVisibleInHierarchy()
  defaultButton.isEnabled()
  defaultButton.getMarkupId()


> Inconsistent use of Button vs. IFormSubmittingComponent
> -------------------------------------------------------
>
>                 Key: WICKET-922
>                 URL: https://issues.apache.org/jira/browse/WICKET-922
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.3.1
>            Reporter: David Leangen
>
> Inconsistent use of the new IFormSubmittingComponent interface.
> Discussion here: http://www.nabble.com/Change-of-Button-interface-tf4370155.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.