You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Joe Bowser (Created) (JIRA)" <ji...@apache.org> on 2012/04/14 01:11:16 UTC
[jira] [Created] (CB-510) loadUrlIntoView on DroidGap is not
Thread-Safe
loadUrlIntoView on DroidGap is not Thread-Safe
----------------------------------------------
Key: CB-510
URL: https://issues.apache.org/jira/browse/CB-510
Project: Apache Callback
Issue Type: Sub-task
Affects Versions: Master
Reporter: Joe Bowser
Priority: Blocker
Fix For: 1.7.0
For some reason, this is no longer thread-safe:
webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
However, it currently works and doesn't throw that error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-510) loadUrlIntoView on DroidGap needs
refactoring
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-510:
--------------------------
Ripped out some code into another protected method, and tried to abstract out a runnable. This makes it a bit more readable, but we still need the weird runnable setup for document timeouts. I'm certain that the browser offers a better solution to this, but I'm not sure what that would be. Going to close this for now.
> loadUrlIntoView on DroidGap needs refactoring
> ---------------------------------------------
>
> Key: CB-510
> URL: https://issues.apache.org/jira/browse/CB-510
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: Master
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Priority: Minor
> Labels: CordovaWebView
> Fix For: 1.8.0
>
>
> For some reason, this shows an error saying that it must be run on the UI thread
> webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
> This leads to ugly code which has us run something on the UI thread, then spawn another thread, and on that thread, run another runnable on the first thread. I think that this will break, and this needs to be refactored. However, it's currently not breaking any functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-510) loadUrlIntoView on DroidGap is not
Thread-Safe
Posted by "Joe Bowser (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-510:
--------------------------
Fix Version/s: (was: 1.7.0)
1.8.0
> loadUrlIntoView on DroidGap is not Thread-Safe
> ----------------------------------------------
>
> Key: CB-510
> URL: https://issues.apache.org/jira/browse/CB-510
> Project: Apache Callback
> Issue Type: Sub-task
> Components: Android
> Affects Versions: Master
> Reporter: Joe Bowser
> Priority: Blocker
> Labels: CordovaWebView
> Fix For: 1.8.0
>
>
> For some reason, this is no longer thread-safe:
> webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
> However, it currently works and doesn't throw that error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-510) loadUrlIntoView on DroidGap needs
refactoring
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-510:
--------------------------
Description:
For some reason, this shows an error saying that it must be run on the UI thread
webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
This leads to ugly code which has us run something on the UI thread, then spawn another thread, and on that thread, run another runnable on the first thread. I think that this will break, and this needs to be refactored. However, it's currently not breaking any functionality.
was:
For some reason, this is no longer thread-safe:
webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
However, it currently works and doesn't throw that error.
Priority: Minor (was: Blocker)
Summary: loadUrlIntoView on DroidGap needs refactoring (was: loadUrlIntoView on DroidGap is not Thread-Safe)
> loadUrlIntoView on DroidGap needs refactoring
> ---------------------------------------------
>
> Key: CB-510
> URL: https://issues.apache.org/jira/browse/CB-510
> Project: Apache Callback
> Issue Type: Sub-task
> Components: Android
> Affects Versions: Master
> Reporter: Joe Bowser
> Priority: Minor
> Labels: CordovaWebView
> Fix For: 1.8.0
>
>
> For some reason, this shows an error saying that it must be run on the UI thread
> webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
> This leads to ugly code which has us run something on the UI thread, then spawn another thread, and on that thread, run another runnable on the first thread. I think that this will break, and this needs to be refactored. However, it's currently not breaking any functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-510) loadUrlIntoView on DroidGap needs
refactoring
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-510:
--------------------------
Issue Type: Improvement (was: Sub-task)
Parent: (was: CB-190)
> loadUrlIntoView on DroidGap needs refactoring
> ---------------------------------------------
>
> Key: CB-510
> URL: https://issues.apache.org/jira/browse/CB-510
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: Master
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Priority: Minor
> Labels: CordovaWebView
> Fix For: 1.8.0
>
>
> For some reason, this shows an error saying that it must be run on the UI thread
> webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
> This leads to ugly code which has us run something on the UI thread, then spawn another thread, and on that thread, run another runnable on the first thread. I think that this will break, and this needs to be refactored. However, it's currently not breaking any functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-510) loadUrlIntoView on DroidGap needs
refactoring
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser reassigned CB-510:
-----------------------------
Assignee: Joe Bowser
> loadUrlIntoView on DroidGap needs refactoring
> ---------------------------------------------
>
> Key: CB-510
> URL: https://issues.apache.org/jira/browse/CB-510
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
> Affects Versions: Master
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Priority: Minor
> Labels: CordovaWebView
> Fix For: 1.8.0
>
>
> For some reason, this shows an error saying that it must be run on the UI thread
> webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
> This leads to ugly code which has us run something on the UI thread, then spawn another thread, and on that thread, run another runnable on the first thread. I think that this will break, and this needs to be refactored. However, it's currently not breaking any functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-510) loadUrlIntoView on DroidGap needs
refactoring
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-510.
---------------------------
Resolution: Later
Not sure if the bug tracker is a good place for this.
> loadUrlIntoView on DroidGap needs refactoring
> ---------------------------------------------
>
> Key: CB-510
> URL: https://issues.apache.org/jira/browse/CB-510
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: Master
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Priority: Minor
> Labels: CordovaWebView
> Fix For: 1.8.0
>
>
> For some reason, this shows an error saying that it must be run on the UI thread
> webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
> This leads to ugly code which has us run something on the UI thread, then spawn another thread, and on that thread, run another runnable on the first thread. I think that this will break, and this needs to be refactored. However, it's currently not breaking any functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira