You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/04/02 14:16:20 UTC
[GitHub] drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk
drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk
URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178552137
##########
File path: tests/src/test/scala/system/basic/WskCliRuleTests.scala
##########
@@ -22,7 +22,35 @@ import org.scalatest.junit.JUnitRunner
import common.Wsk
+import spray.json._
+import spray.json.DefaultJsonProtocol._
+
@RunWith(classOf[JUnitRunner])
class WskCliRuleTests extends WskRuleTests {
override val wsk: Wsk = new Wsk
+
+ it should "preserve rule status when a rule is updated" in withAssetCleaner(wskprops) { (wp, assetHelper) =>
Review comment:
see https://github.com/apache/incubator-openwhisk/pull/3503/files#r178551945
I can merge the tests w/ some logic if we find that is more appropriate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services