You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@cpan.org> on 2002/12/11 17:19:30 UTC

[Patch] Apache-Test thinks docs/devel/core is a core file ;-)

Small patch that ensures that a core file is a file, nothing else.

Index: Apache-Test/lib/Apache/TestRun.pm
===================================================================
RCS file: /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.96
diff -b -B -u -r1.96 TestRun.pm
--- Apache-Test/lib/Apache/TestRun.pm	7 Nov 2002 06:39:48 -0000	1.96
+++ Apache-Test/lib/Apache/TestRun.pm	11 Dec 2002 16:16:46 -0000
@@ -610,6 +610,7 @@
     my $times = 0;
 
     finddepth(sub {
+        return unless -f $_;
         return unless /$core_pat/o;
         my $core = "$File::Find::dir/$_";
         if (exists $core_files{$core} && $core_files{$core} == -M $core) {
@@ -634,6 +635,7 @@
     %core_files = (); # reset global
 
     finddepth(sub {
+        return unless -f $_;
         return unless /$core_pat/o;
         my $core = "$File::Find::dir/$_";
         info "consider removing an old $core file before running tests";

--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5
(122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107
88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so
ingenious.
perl
-e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Re: [Patch] Apache-Test thinks docs/devel/core is a core file ;-)

Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> Small patch that ensures that a core file is a file, nothing else.

committed, merci beaucoup!

Should I pick a better name for the internals docs dir (now devel/core/? like 
/devel/guts/?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org