You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/08 19:17:36 UTC

[GitHub] seelmann commented on a change in pull request #4408: [AIRFLOW-3589] Visualize reschedule state in all views

seelmann commented on a change in pull request #4408: [AIRFLOW-3589] Visualize reschedule state in all views
URL: https://github.com/apache/airflow/pull/4408#discussion_r246119192
 
 

 ##########
 File path: airflow/jobs.py
 ##########
 @@ -947,7 +947,8 @@ def _process_task_instances(self, dag, queue, session=None):
             self.log.debug("Examining active DAG run: %s", run)
             # this needs a fresh session sometimes tis get detached
             tis = run.get_task_instances(state=(State.NONE,
 
 Review comment:
   In this case it's even a tuple `()`. Also, here it's not a `needle in ['hay','stack']` pattern, but the tuple is passed to a function `DagRun.get_task_instances()` which uses the tuple for a SQLalchemy query, so I'd rather not change it in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services